2018-10-05 16:13:28

by Arnd Bergmann

Subject: [PATCH] clk: keystone: add missing MODULE_LICENSE

A randconfig build showed that two clk modules have no license tag:

WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/gate.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/pll.o
see include/linux/module.h for more information

Add the appropriate information from the comment at the start of the
two files.

Signed-off-by: Arnd Bergmann <[email protected]>
---
I had not seen this until today, no idea why it showed up now on arm64.
---
drivers/clk/keystone/gate.c | 5 +++++
drivers/clk/keystone/pll.c | 5 +++++
2 files changed, 10 insertions(+)

diff --git a/drivers/clk/keystone/gate.c b/drivers/clk/keystone/gate.c
index def15db4eef0..4ed9b29ba438 100644
--- a/drivers/clk/keystone/gate.c
+++ b/drivers/clk/keystone/gate.c
@@ -266,3 +266,8 @@ static void __init of_keystone_psc_clk_init(struct device_node *node)
}
CLK_OF_DECLARE(keystone_gate_clk, "ti,keystone,psc-clock",
of_keystone_psc_clk_init);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Clock driver for Keystone 2 based devices");
+MODULE_AUTHOR("Murali Karicheri <[email protected]>");
+MODULE_AUTHOR("Santosh Shilimkar <[email protected]>");
diff --git a/drivers/clk/keystone/pll.c b/drivers/clk/keystone/pll.c
index 2b871fc91d56..349540469fc0 100644
--- a/drivers/clk/keystone/pll.c
+++ b/drivers/clk/keystone/pll.c
@@ -338,3 +338,8 @@ static void __init of_pll_mux_clk_init(struct device_node *node)
pr_err("%s: error registering mux %s\n", __func__, clk_name);
}
CLK_OF_DECLARE(pll_mux_clock, "ti,keystone,pll-mux-clock", of_pll_mux_clk_init);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("PLL clock driver for Keystone devices");
+MODULE_AUTHOR("Murali Karicheri <[email protected]>");
+MODULE_AUTHOR("Santosh Shilimkar <[email protected]>");
--
2.18.0

2018-10-05 18:12:17

by Santosh Shilimkar

Subject: Re: [PATCH] clk: keystone: add missing MODULE_LICENSE

On 10/5/2018 9:11 AM, Arnd Bergmann wrote:
> A randconfig build showed that two clk modules have no license tag:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/gate.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/pll.o
> see include/linux/module.h for more information
>
> Add the appropriate information from the comment at the start of the
> two files.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
Thanks Arnd.
Acked-by: Santosh Shilimkar <[email protected]>

2018-10-08 02:55:17

by Stephen Boyd

Subject: Re: [PATCH] clk: keystone: add missing MODULE_LICENSE

Quoting Arnd Bergmann (2018-10-05 09:11:15)
> A randconfig build showed that two clk modules have no license tag:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/gate.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/pll.o
> see include/linux/module.h for more information
>
> Add the appropriate information from the comment at the start of the
> two files.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---

Applied to clk-next