2017-08-03 22:38:43

by Dragos Bogdan

[permalink] [raw]
Subject: [PATCH] iio: imu: adis16480: Fix acceleration scale factor for adis16480

According to the datasheet, the range of the acceleration is [-10 g, + 10 g],
so the scale factor should be 10 instead of 5.

Signed-off-by: Dragos Bogdan <[email protected]>
---
drivers/iio/imu/adis16480.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
index 8cf84d3488b2..12898424d838 100644
--- a/drivers/iio/imu/adis16480.c
+++ b/drivers/iio/imu/adis16480.c
@@ -696,7 +696,7 @@ static const struct adis16480_chip_info adis16480_chip_info[] = {
.gyro_max_val = IIO_RAD_TO_DEGREE(22500),
.gyro_max_scale = 450,
.accel_max_val = IIO_M_S_2_TO_G(12500),
- .accel_max_scale = 5,
+ .accel_max_scale = 10,
},
[ADIS16485] = {
.channels = adis16485_channels,
--
2.11.0


2017-08-04 03:49:41

by Lars-Peter Clausen

[permalink] [raw]
Subject: Re: [PATCH] iio: imu: adis16480: Fix acceleration scale factor for adis16480

On 08/04/2017 12:37 AM, Dragos Bogdan wrote:
> According to the datasheet, the range of the acceleration is [-10 g, + 10 g],
> so the scale factor should be 10 instead of 5.
>
> Signed-off-by: Dragos Bogdan <[email protected]>

Acked-by: Lars-Peter Clausen <[email protected]>

Thanks.

> ---
> drivers/iio/imu/adis16480.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> index 8cf84d3488b2..12898424d838 100644
> --- a/drivers/iio/imu/adis16480.c
> +++ b/drivers/iio/imu/adis16480.c
> @@ -696,7 +696,7 @@ static const struct adis16480_chip_info adis16480_chip_info[] = {
> .gyro_max_val = IIO_RAD_TO_DEGREE(22500),
> .gyro_max_scale = 450,
> .accel_max_val = IIO_M_S_2_TO_G(12500),
> - .accel_max_scale = 5,
> + .accel_max_scale = 10,
> },
> [ADIS16485] = {
> .channels = adis16485_channels,
>

2017-08-09 14:38:52

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] iio: imu: adis16480: Fix acceleration scale factor for adis16480

On Fri, 4 Aug 2017 05:49:32 +0200
Lars-Peter Clausen <[email protected]> wrote:

> On 08/04/2017 12:37 AM, Dragos Bogdan wrote:
> > According to the datasheet, the range of the acceleration is [-10 g, + 10 g],
> > so the scale factor should be 10 instead of 5.
> >
> > Signed-off-by: Dragos Bogdan <[email protected]>
>
> Acked-by: Lars-Peter Clausen <[email protected]>
>
> Thanks.
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan
>
> > ---
> > drivers/iio/imu/adis16480.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> > index 8cf84d3488b2..12898424d838 100644
> > --- a/drivers/iio/imu/adis16480.c
> > +++ b/drivers/iio/imu/adis16480.c
> > @@ -696,7 +696,7 @@ static const struct adis16480_chip_info adis16480_chip_info[] = {
> > .gyro_max_val = IIO_RAD_TO_DEGREE(22500),
> > .gyro_max_scale = 450,
> > .accel_max_val = IIO_M_S_2_TO_G(12500),
> > - .accel_max_scale = 5,
> > + .accel_max_scale = 10,
> > },
> > [ADIS16485] = {
> > .channels = adis16485_channels,
> >
>