2020-09-15 18:06:15

by Krish Sadhukhan

[permalink] [raw]
Subject: Re: [PATCH] KVM: SVM: Get rid of the variable 'exit_fastpath'


On 9/15/20 4:30 AM, [email protected] wrote:
> From: Haiwei Li <[email protected]>
>
> 'exit_fastpath' isn't used anywhere else, so remove it.
>
> Suggested-by: Krish Sadhukhan <[email protected]>
> Signed-off-by: Haiwei Li <[email protected]>
> ---
> arch/x86/kvm/svm/svm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index c44f3e9..6e88658 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -3413,7 +3413,6 @@ static noinstr void svm_vcpu_enter_exit(struct kvm_vcpu *vcpu,
>
> static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
> {
> - fastpath_t exit_fastpath;
> struct vcpu_svm *svm = to_svm(vcpu);
>
> svm->vmcb->save.rax = vcpu->arch.regs[VCPU_REGS_RAX];
> @@ -3536,8 +3535,7 @@ static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
> svm_handle_mce(svm);
>
> svm_complete_interrupts(svm);
> - exit_fastpath = svm_exit_handlers_fastpath(vcpu);
> - return exit_fastpath;
> + return svm_exit_handlers_fastpath(vcpu);
> }
>
> static void svm_load_mmu_pgd(struct kvm_vcpu *vcpu, unsigned long root,
Reviewed-by: Krish Sadhukhan <[email protected]>