2020-09-10 11:01:02

by Andrew Jeffery

Subject: [PATCH 1/3] dt: bindings: mmc: Add phase control properties for the Aspeed SDHCI

Add properties to control the phase delay for input and output data
sampling.

Signed-off-by: Andrew Jeffery <[email protected]>
---
Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
index 987b287f3bff..75effd411554 100644
--- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
@@ -61,6 +61,14 @@ patternProperties:
sdhci,auto-cmd12:
type: boolean
description: Specifies that controller should use auto CMD12
+ "aspeed,input-phase":
+ $ref: '/schemas/types.yaml#/definitions/uint32'
+ description:
+ The input clock phase delay value.
+ "aspeed,output-phase":
+ $ref: '/schemas/types.yaml#/definitions/uint32'
+ description:
+ The output clock phase delay value.
required:
- compatible
- reg
--
2.25.1

2020-09-14 09:43:22

by Ulf Hansson

Subject: Re: [PATCH 1/3] dt: bindings: mmc: Add phase control properties for the Aspeed SDHCI

On Thu, 10 Sep 2020 at 12:54, Andrew Jeffery <[email protected]> wrote:
>
> Add properties to control the phase delay for input and output data
> sampling.
>
> Signed-off-by: Andrew Jeffery <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> index 987b287f3bff..75effd411554 100644
> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> @@ -61,6 +61,14 @@ patternProperties:
> sdhci,auto-cmd12:
> type: boolean
> description: Specifies that controller should use auto CMD12
> + "aspeed,input-phase":
> + $ref: '/schemas/types.yaml#/definitions/uint32'
> + description:
> + The input clock phase delay value.
> + "aspeed,output-phase":
> + $ref: '/schemas/types.yaml#/definitions/uint32'
> + description:
> + The output clock phase delay value.

We already have a common mmc clk-phase* binding, see
mmc-controller.yaml. As matter of fact, there is one binding per speed
mode.

Could that work for this case as well?

Kind regards
Uffe

2020-09-15 00:45:32

by Andrew Jeffery

Subject: Re: [PATCH 1/3] dt: bindings: mmc: Add phase control properties for the Aspeed SDHCI

On Mon, 14 Sep 2020, at 19:11, Ulf Hansson wrote:
> On Thu, 10 Sep 2020 at 12:54, Andrew Jeffery <[email protected]> wrote:
> >
> > Add properties to control the phase delay for input and output data
> > sampling.
> >
> > Signed-off-by: Andrew Jeffery <[email protected]>
> > ---
> > Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > index 987b287f3bff..75effd411554 100644
> > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > @@ -61,6 +61,14 @@ patternProperties:
> > sdhci,auto-cmd12:
> > type: boolean
> > description: Specifies that controller should use auto CMD12
> > + "aspeed,input-phase":
> > + $ref: '/schemas/types.yaml#/definitions/uint32'
> > + description:
> > + The input clock phase delay value.
> > + "aspeed,output-phase":
> > + $ref: '/schemas/types.yaml#/definitions/uint32'
> > + description:
> > + The output clock phase delay value.
>
> We already have a common mmc clk-phase* binding, see
> mmc-controller.yaml. As matter of fact, there is one binding per speed
> mode.
>
> Could that work for this case as well?

Ah, great, I think so. Sorry for overlooking that. I just need to extract from
Aspeed what units the damn register fields are using :/

Andrew