2023-07-12 13:49:29

by huzhi001

Subject: [PATCH] SVM: Fix warnings in svm.h

The following checkpatch warnings are removed:
WARNING: Prefer __packed over __attribute__((__packed__))

Signed-off-by: ZhiHu <[email protected]>
---
arch/x86/include/asm/svm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
index e7c7379d6ac7..7ecebccf8a83 100644
--- a/arch/x86/include/asm/svm.h
+++ b/arch/x86/include/asm/svm.h
@@ -119,7 +119,7 @@ enum {
};

-struct __attribute__ ((__packed__)) vmcb_control_area {
+struct __packed vmcb_control_area {
u32 intercepts[MAX_INTERCEPT];
u32 reserved_1[15 - MAX_INTERCEPT];
u16 pause_filter_thresh;

2023-07-12 14:05:47

by Peter Zijlstra

Subject: Re: [PATCH] SVM: Fix warnings in svm.h

On Wed, Jul 12, 2023 at 09:39:24PM +0800, [email protected] wrote:
> The following checkpatch warnings are removed:
> WARNING: Prefer __packed over __attribute__((__packed__))

Can you please stop with these pointless checkpatch things?

2023-07-12 15:19:21

by Randy Dunlap

Subject: Re: [PATCH] SVM: Fix warnings in svm.h

On 7/12/23 06:59, Peter Zijlstra wrote:
> On Wed, Jul 12, 2023 at 09:39:24PM +0800, [email protected] wrote:
>> The following checkpatch warnings are removed:
>> WARNING: Prefer __packed over __attribute__((__packed__))
>
> Can you please stop with these pointless checkpatch things?

We should probably document that checkpatch should usually just be used
on patches and not on entire files.

--
~Randy