2018-04-16 09:21:35

by Wei Xu

Subject: [PATCH] lightnvm: pblk: add CNEX Granby to the pblk device list

Add a new lightnvm quirk to identify CNEX’s Granby controller.

Signed-off-by: Wei Xu <[email protected]>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index cb73bc8..9419e88 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_LIGHTNVM, },
{ PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
.driver_data = NVME_QUIRK_LIGHTNVM, },
+ { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
+ .driver_data = NVME_QUIRK_LIGHTNVM, },
{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
--
2.7.4

2018-04-16 18:49:11

by Matias Bjørling

Subject: Re: [PATCH] lightnvm: pblk: add CNEX Granby to the pblk device list

On 4/16/18 11:19 AM, Wei Xu wrote:

> Add a new lightnvm quirk to identify CNEX’s Granby controller.
>
> Signed-off-by: Wei Xu <[email protected]>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index cb73bc8..9419e88 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> + .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
Hi Wei,

The patch looks good, but the title is not description of the change.

Could the title be changed to "nvme: lightnvm: add granby support".
Also, please send it to the nvme mailing list and CC Keith Busch. It is
a pure NVMe device driver change, and can go directly up through the
NVMe maintainers. I'll add a Reviewed-by: when you've sent it.

-Matias