2021-12-18 11:23:49

by Chengguang Xu

Subject: [PATCH] RDMA/rxe: fix a typo in opcode name

There is a redundant ']' in the name of opcode IB_OPCODE_RC_SEND_MIDDLE,
so just fix it.

Signed-off-by: Chengguang Xu <[email protected]>
---
drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
index 3ef5a10a6efd..47ebaac8f475 100644
--- a/drivers/infiniband/sw/rxe/rxe_opcode.c
+++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
@@ -117,7 +117,7 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
}
},
[IB_OPCODE_RC_SEND_MIDDLE] = {
- .name = "IB_OPCODE_RC_SEND_MIDDLE]",
+ .name = "IB_OPCODE_RC_SEND_MIDDLE",
.mask = RXE_PAYLOAD_MASK | RXE_REQ_MASK | RXE_SEND_MASK
| RXE_MIDDLE_MASK,
.length = RXE_BTH_BYTES,
--
2.27.0

2021-12-19 03:36:44

by Zhu Yanjun

Subject: Re: [PATCH] RDMA/rxe: fix a typo in opcode name

On Sat, Dec 18, 2021 at 7:23 PM Chengguang Xu <[email protected]> wrote:
>
> There is a redundant ']' in the name of opcode IB_OPCODE_RC_SEND_MIDDLE,
> so just fix it.
>
> Signed-off-by: Chengguang Xu <[email protected]>

Acked-by: Zhu Yanjun <[email protected]>

Zhu Yanjun

> ---
> drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
> index 3ef5a10a6efd..47ebaac8f475 100644
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -117,7 +117,7 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> }
> },
> [IB_OPCODE_RC_SEND_MIDDLE] = {
> - .name = "IB_OPCODE_RC_SEND_MIDDLE]",
> + .name = "IB_OPCODE_RC_SEND_MIDDLE",
> .mask = RXE_PAYLOAD_MASK | RXE_REQ_MASK | RXE_SEND_MASK
> | RXE_MIDDLE_MASK,
> .length = RXE_BTH_BYTES,
> --
> 2.27.0
>
>

2021-12-20 18:03:56

by Bob Pearson

Subject: Re: [PATCH] RDMA/rxe: fix a typo in opcode name

On 12/18/21 05:23, Chengguang Xu wrote:
> There is a redundant ']' in the name of opcode IB_OPCODE_RC_SEND_MIDDLE,
> so just fix it.
>
> Signed-off-by: Chengguang Xu <[email protected]>
> ---
> drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
> index 3ef5a10a6efd..47ebaac8f475 100644
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -117,7 +117,7 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> }
> },
> [IB_OPCODE_RC_SEND_MIDDLE] = {
> - .name = "IB_OPCODE_RC_SEND_MIDDLE]",
> + .name = "IB_OPCODE_RC_SEND_MIDDLE",
> .mask = RXE_PAYLOAD_MASK | RXE_REQ_MASK | RXE_SEND_MASK
> | RXE_MIDDLE_MASK,
> .length = RXE_BTH_BYTES,
>

Looks good

Reviewed-by: Bob Pearson <[email protected]>

2022-01-05 19:06:32

by Jason Gunthorpe

Subject: Re: [PATCH] RDMA/rxe: fix a typo in opcode name

On Sat, Dec 18, 2021 at 07:23:20PM +0800, Chengguang Xu wrote:
> There is a redundant ']' in the name of opcode IB_OPCODE_RC_SEND_MIDDLE,
> so just fix it.
>
> Signed-off-by: Chengguang Xu <[email protected]>
> Acked-by: Zhu Yanjun <[email protected]>
> Reviewed-by: Bob Pearson <[email protected]>
> ---
> drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

I added a fixes line

Jason