2022-11-14 08:49:36

by Kai-Heng Feng

Subject: [PATCH] platform/x86: hp-wmi: Ignore Smart Experience App event

Sometimes hp-wmi driver complains on system resume:
[ 483.116451] hp_wmi: Unknown event_id - 33 - 0x0

According to HP it's a feature called "HP Smart Experience App" and it's
safe to be ignored.

Signed-off-by: Kai-Heng Feng <[email protected]>
---
drivers/platform/x86/hp-wmi.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index 12449038bed12..0a99058be8130 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -90,6 +90,7 @@ enum hp_wmi_event_ids {
HPWMI_PEAKSHIFT_PERIOD = 0x0F,
HPWMI_BATTERY_CHARGE_PERIOD = 0x10,
HPWMI_SANITIZATION_MODE = 0x17,
+ HPWMI_SMART_EXPERIENCE_APP = 0x21,
};

/*
@@ -859,6 +860,8 @@ static void hp_wmi_notify(u32 value, void *context)
break;
case HPWMI_SANITIZATION_MODE:
break;
+ case HPWMI_SMART_EXPERIENCE_APP:
+ break;
default:
pr_info("Unknown event_id - %d - 0x%x\n", event_id, event_data);
break;
--
2.34.1

2022-11-14 20:38:12

by Mario Limonciello

Subject: Re: [PATCH] platform/x86: hp-wmi: Ignore Smart Experience App event

+Jorge Lopez @ HP

On 11/14/2022 01:38, Kai-Heng Feng wrote:
> Sometimes hp-wmi driver complains on system resume:
> [ 483.116451] hp_wmi: Unknown event_id - 33 - 0x0
>
> According to HP it's a feature called "HP Smart Experience App" and it's
> safe to be ignored.
>
> Signed-off-by: Kai-Heng Feng <[email protected]>
> ---
> drivers/platform/x86/hp-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>

Jorge,

Can you please review KH's submission?

Also to avoid playing wack-a-mole, can you cross reference your internal
specs against any other missing event IDs and send follow up patches if
anything else is missing?

Thanks,

> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index 12449038bed12..0a99058be8130 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -90,6 +90,7 @@ enum hp_wmi_event_ids {
> HPWMI_PEAKSHIFT_PERIOD = 0x0F,
> HPWMI_BATTERY_CHARGE_PERIOD = 0x10,
> HPWMI_SANITIZATION_MODE = 0x17,
> + HPWMI_SMART_EXPERIENCE_APP = 0x21,
> };
>
> /*
> @@ -859,6 +860,8 @@ static void hp_wmi_notify(u32 value, void *context)
> break;
> case HPWMI_SANITIZATION_MODE:
> break;
> + case HPWMI_SMART_EXPERIENCE_APP:
> + break;
> default:
> pr_info("Unknown event_id - %d - 0x%x\n", event_id, event_data);
> break;

2022-11-15 16:46:24

by Hans de Goede

Subject: Re: [PATCH] platform/x86: hp-wmi: Ignore Smart Experience App event

Hi,

On 11/14/22 08:38, Kai-Heng Feng wrote:
> Sometimes hp-wmi driver complains on system resume:
> [ 483.116451] hp_wmi: Unknown event_id - 33 - 0x0
>
> According to HP it's a feature called "HP Smart Experience App" and it's
> safe to be ignored.
>
> Signed-off-by: Kai-Heng Feng <[email protected]>

Thank you for your patch, I've applied this patch to my fixes
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans



> ---
> drivers/platform/x86/hp-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index 12449038bed12..0a99058be8130 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -90,6 +90,7 @@ enum hp_wmi_event_ids {
> HPWMI_PEAKSHIFT_PERIOD = 0x0F,
> HPWMI_BATTERY_CHARGE_PERIOD = 0x10,
> HPWMI_SANITIZATION_MODE = 0x17,
> + HPWMI_SMART_EXPERIENCE_APP = 0x21,
> };
>
> /*
> @@ -859,6 +860,8 @@ static void hp_wmi_notify(u32 value, void *context)
> break;
> case HPWMI_SANITIZATION_MODE:
> break;
> + case HPWMI_SMART_EXPERIENCE_APP:
> + break;
> default:
> pr_info("Unknown event_id - %d - 0x%x\n", event_id, event_data);
> break;