2019-12-26 12:13:53

by Yu Kuai

Subject: [PATCH] drm/bridge: cdns: remove set but not used variable 'bpp'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/bridge/cdns-dsi.c: In function
‘cdns_dsi_bridge_enable’:
drivers/gpu/drm/bridge/cdns-dsi.c:788:6: warning: variable ‘bpp’
set but not used [-Wunused-but-set-variable]

It is never used, and so can be removed.

Signed-off-by: yu kuai <[email protected]>
---
drivers/gpu/drm/bridge/cdns-dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c
index a6ab2d281a9b..b7c97f060241 100644
--- a/drivers/gpu/drm/bridge/cdns-dsi.c
+++ b/drivers/gpu/drm/bridge/cdns-dsi.c
@@ -784,13 +784,12 @@ static void cdns_dsi_bridge_enable(struct drm_bridge *bridge)
unsigned long tx_byte_period;
struct cdns_dsi_cfg dsi_cfg;
u32 tmp, reg_wakeup, div;
- int bpp, nlanes;
+ int nlanes;

if (WARN_ON(pm_runtime_get_sync(dsi->base.dev) < 0))
return;

mode = &bridge->encoder->crtc->state->adjusted_mode;
- bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format);
nlanes = output->dev->lanes;

WARN_ON_ONCE(cdns_dsi_check_conf(dsi, mode, &dsi_cfg, false));
--
2.17.2

2020-01-06 15:08:58

by Neil Armstrong

Subject: Re: [PATCH] drm/bridge: cdns: remove set but not used variable 'bpp'

On 26/12/2019 13:12, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/bridge/cdns-dsi.c: In function
> ‘cdns_dsi_bridge_enable’:
> drivers/gpu/drm/bridge/cdns-dsi.c:788:6: warning: variable ‘bpp’
> set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <[email protected]>
> ---
> drivers/gpu/drm/bridge/cdns-dsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c
> index a6ab2d281a9b..b7c97f060241 100644
> --- a/drivers/gpu/drm/bridge/cdns-dsi.c
> +++ b/drivers/gpu/drm/bridge/cdns-dsi.c
> @@ -784,13 +784,12 @@ static void cdns_dsi_bridge_enable(struct drm_bridge *bridge)
> unsigned long tx_byte_period;
> struct cdns_dsi_cfg dsi_cfg;
> u32 tmp, reg_wakeup, div;
> - int bpp, nlanes;
> + int nlanes;
>
> if (WARN_ON(pm_runtime_get_sync(dsi->base.dev) < 0))
> return;
>
> mode = &bridge->encoder->crtc->state->adjusted_mode;
> - bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format);
> nlanes = output->dev->lanes;
>
> WARN_ON_ONCE(cdns_dsi_check_conf(dsi, mode, &dsi_cfg, false));
>


Reviewed-by: Neil Armstrong <[email protected]>

and applying to drm-misc-next