2023-12-16 14:08:27

by Aleksa Savic

Subject: [PATCH] hwmon: (aquacomputer_d5next) Remove unneeded CONFIG_DEBUG_FS #ifdef

Remove the #ifdef check for CONFIG_DEBUG_FS and the empty variant
of aqc_debugfs_init(), because the debugfs functions already do nothing
if debugfs isn't enabled.

Signed-off-by: Aleksa Savic <[email protected]>
---
drivers/hwmon/aquacomputer_d5next.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/hwmon/aquacomputer_d5next.c b/drivers/hwmon/aquacomputer_d5next.c
index 4fdd2e12427b..2efe97f8d003 100644
--- a/drivers/hwmon/aquacomputer_d5next.c
+++ b/drivers/hwmon/aquacomputer_d5next.c
@@ -1476,8 +1476,6 @@ static int aqc_raw_event(struct hid_device *hdev, struct hid_report *report, u8
return 0;
}

-#ifdef CONFIG_DEBUG_FS
-
static int serial_number_show(struct seq_file *seqf, void *unused)
{
struct aqc_data *priv = seqf->private;
@@ -1527,14 +1525,6 @@ static void aqc_debugfs_init(struct aqc_data *priv)
debugfs_create_file("power_cycles", 0444, priv->debugfs, priv, &power_cycles_fops);
}

-#else
-
-static void aqc_debugfs_init(struct aqc_data *priv)
-{
-}
-
-#endif
-
static int aqc_probe(struct hid_device *hdev, const struct hid_device_id *id)
{
struct aqc_data *priv;
--
2.43.0

2023-12-17 15:11:10

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Remove unneeded CONFIG_DEBUG_FS #ifdef

On Sat, Dec 16, 2023 at 03:07:54PM +0100, Aleksa Savic wrote:
> Remove the #ifdef check for CONFIG_DEBUG_FS and the empty variant
> of aqc_debugfs_init(), because the debugfs functions already do nothing
> if debugfs isn't enabled.
>
> Signed-off-by: Aleksa Savic <[email protected]>

Applied.

Thanks,
Guenter