2022-07-19 10:24:58

by Christophe JAILLET

Subject: [PATCH 3/3] ocfs2: use the bitmap API to simplify code

Use bitmap_zero() instead of hand-writing it.
It is less verbose.

While at it, add an explicit #include <linux/bitmap.h>.

Signed-off-by: Christophe JAILLET <[email protected]>
---
fs/ocfs2/heartbeat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ocfs2/heartbeat.c b/fs/ocfs2/heartbeat.c
index 4863ad35c242..e243cd99e63f 100644
--- a/fs/ocfs2/heartbeat.c
+++ b/fs/ocfs2/heartbeat.c
@@ -8,6 +8,7 @@
* Copyright (C) 2002, 2004 Oracle. All rights reserved.
*/

+#include <linux/bitmap.h>
#include <linux/fs.h>
#include <linux/types.h>
#include <linux/highmem.h>
@@ -29,8 +30,7 @@
static void ocfs2_node_map_init(struct ocfs2_node_map *map)
{
map->num_nodes = OCFS2_NODE_MAP_MAX_NODES;
- memset(map->map, 0, BITS_TO_LONGS(OCFS2_NODE_MAP_MAX_NODES) *
- sizeof(unsigned long));
+ bitmap_zero(map->map, OCFS2_NODE_MAP_MAX_NODES);
}

void ocfs2_init_node_maps(struct ocfs2_super *osb)
--
2.34.1

2022-07-20 02:07:45

by Joseph Qi

Subject: Re: [PATCH 3/3] ocfs2: use the bitmap API to simplify code

On 7/19/22 6:05 PM, Christophe JAILLET wrote:
> Use bitmap_zero() instead of hand-writing it.
> It is less verbose.
>
> While at it, add an explicit #include <linux/bitmap.h>.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: Joseph Qi <[email protected]>
> ---
> fs/ocfs2/heartbeat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/heartbeat.c b/fs/ocfs2/heartbeat.c
> index 4863ad35c242..e243cd99e63f 100644
> --- a/fs/ocfs2/heartbeat.c
> +++ b/fs/ocfs2/heartbeat.c
> @@ -8,6 +8,7 @@
> * Copyright (C) 2002, 2004 Oracle. All rights reserved.
> */
>
> +#include <linux/bitmap.h>
> #include <linux/fs.h>
> #include <linux/types.h>
> #include <linux/highmem.h>
> @@ -29,8 +30,7 @@
> static void ocfs2_node_map_init(struct ocfs2_node_map *map)
> {
> map->num_nodes = OCFS2_NODE_MAP_MAX_NODES;
> - memset(map->map, 0, BITS_TO_LONGS(OCFS2_NODE_MAP_MAX_NODES) *
> - sizeof(unsigned long));
> + bitmap_zero(map->map, OCFS2_NODE_MAP_MAX_NODES);
> }
>
> void ocfs2_init_node_maps(struct ocfs2_super *osb)