2015-07-27 22:57:46

by Jilai Wang

Subject: [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm

Add plane properties hflip/vflip which are used in MDP driver to flip
the input horizontally/vertically.

Signed-off-by: Jilai Wang <[email protected]>
---
Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index d9f5613..bef6d34 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
<td valign="top" >TBD</td>
</tr>
<tr>
- <td rowspan="3" valign="top" >msm</td>
- <td rowspan="3" valign="top" >Generic</td>
+ <td rowspan="5" valign="top" >msm</td>
+ <td rowspan="5" valign="top" >Generic</td>
<td valign="top" >"premultiplied"</td>
<td valign="top" >ENUM</td>
<td valign="top" >{ "false", "true" }</td>
@@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
<td valign="top" >Plane</td>
<td valign="top" >property to set plane's z position during blending</td>
</tr>
+ <tr>
+ <td valign="top" >"hflip"</td>
+ <td valign="top" >ENUM</td>
+ <td valign="top" >{ "off", "on" }</td>
+ <td valign="top" >Plane</td>
+ <td valign="top" >property to flip the input horizontally</td>
+ </tr>
+ <tr>
+ <td valign="top" >"vflip"</td>
+ <td valign="top" >ENUM</td>
+ <td valign="top" >{ "off", "on" }</td>
+ <td valign="top" >Plane</td>
+ <td valign="top" >property to flip the input vertically</td>
+ </tr>
</tbody>
</table>
</sect2>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2015-07-28 08:27:07

by Daniel Vetter

Subject: Re: [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm

On Mon, Jul 27, 2015 at 06:57:33PM -0400, Jilai Wang wrote:
> Add plane properties hflip/vflip which are used in MDP driver to flip
> the input horizontally/vertically.
>
> Signed-off-by: Jilai Wang <[email protected]>

Is the existing rotation prop with flip masks not enough?
-Daniel

> ---
> Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index d9f5613..bef6d34 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
> <td valign="top" >TBD</td>
> </tr>
> <tr>
> - <td rowspan="3" valign="top" >msm</td>
> - <td rowspan="3" valign="top" >Generic</td>
> + <td rowspan="5" valign="top" >msm</td>
> + <td rowspan="5" valign="top" >Generic</td>
> <td valign="top" >"premultiplied"</td>
> <td valign="top" >ENUM</td>
> <td valign="top" >{ "false", "true" }</td>
> @@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
> <td valign="top" >Plane</td>
> <td valign="top" >property to set plane's z position during blending</td>
> </tr>
> + <tr>
> + <td valign="top" >"hflip"</td>
> + <td valign="top" >ENUM</td>
> + <td valign="top" >{ "off", "on" }</td>
> + <td valign="top" >Plane</td>
> + <td valign="top" >property to flip the input horizontally</td>
> + </tr>
> + <tr>
> + <td valign="top" >"vflip"</td>
> + <td valign="top" >ENUM</td>
> + <td valign="top" >{ "off", "on" }</td>
> + <td valign="top" >Plane</td>
> + <td valign="top" >property to flip the input vertically</td>
> + </tr>
> </tbody>
> </table>
> </sect2>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2015-07-29 20:50:06

by Jilai Wang

Subject: Re: [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm

Thanks for this information, Daniel.
I will change it to use rotation prop in next patch.
> On Mon, Jul 27, 2015 at 06:57:33PM -0400, Jilai Wang wrote:
>> Add plane properties hflip/vflip which are used in MDP driver to flip
>> the input horizontally/vertically.
>>
>> Signed-off-by: Jilai Wang <[email protected]>
>
> Is the existing rotation prop with flip masks not enough?
> -Daniel
>
>> ---
>> Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
>> 1 file changed, 16 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/DocBook/drm.tmpl
>> b/Documentation/DocBook/drm.tmpl
>> index d9f5613..bef6d34 100644
>> --- a/Documentation/DocBook/drm.tmpl
>> +++ b/Documentation/DocBook/drm.tmpl
>> @@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
>> <td valign="top" >TBD</td>
>> </tr>
>> <tr>
>> - <td rowspan="3" valign="top" >msm</td>
>> - <td rowspan="3" valign="top" >Generic</td>
>> + <td rowspan="5" valign="top" >msm</td>
>> + <td rowspan="5" valign="top" >Generic</td>
>> <td valign="top" >"premultiplied"</td>
>> <td valign="top" >ENUM</td>
>> <td valign="top" >{ "false", "true" }</td>
>> @@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
>> <td valign="top" >Plane</td>
>> <td valign="top" >property to set plane's z position during
>> blending</td>
>> </tr>
>> + <tr>
>> + <td valign="top" >"hflip"</td>
>> + <td valign="top" >ENUM</td>
>> + <td valign="top" >{ "off", "on" }</td>
>> + <td valign="top" >Plane</td>
>> + <td valign="top" >property to flip the input horizontally</td>
>> + </tr>
>> + <tr>
>> + <td valign="top" >"vflip"</td>
>> + <td valign="top" >ENUM</td>
>> + <td valign="top" >{ "off", "on" }</td>
>> + <td valign="top" >Plane</td>
>> + <td valign="top" >property to flip the input vertically</td>
>> + </tr>
>> </tbody>
>> </table>
>> </sect2>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
>> _______________________________________________
>> dri-devel mailing list
>> [email protected]
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>