2020-10-22 08:59:10

by Jan Beulich

Subject: Re: [PATCH 4/5] xen/events: unmask a fifo event channel only if it was masked

On 22.10.2020 09:42, Juergen Gross wrote:
> --- a/drivers/xen/events/events_fifo.c
> +++ b/drivers/xen/events/events_fifo.c
> @@ -236,6 +236,9 @@ static bool clear_masked_cond(volatile event_word_t *word)
>
> w = *word;
>
> + if (!(w & (1 << EVTCHN_FIFO_MASKED)))
> + return true;

Maybe better move this ...

> do {
> if (w & (1 << EVTCHN_FIFO_PENDING))
> return false;
>

... into the loop, above this check?

Jan

2020-10-22 09:07:44

by Jürgen Groß

Subject: Re: [PATCH 4/5] xen/events: unmask a fifo event channel only if it was masked

On 22.10.20 09:55, Jan Beulich wrote:
> On 22.10.2020 09:42, Juergen Gross wrote:
>> --- a/drivers/xen/events/events_fifo.c
>> +++ b/drivers/xen/events/events_fifo.c
>> @@ -236,6 +236,9 @@ static bool clear_masked_cond(volatile event_word_t *word)
>>
>> w = *word;
>>
>> + if (!(w & (1 << EVTCHN_FIFO_MASKED)))
>> + return true;
>
> Maybe better move this ...
>
>> do {
>> if (w & (1 << EVTCHN_FIFO_PENDING))
>> return false;
>>
>
> ... into the loop, above this check?

Yes, that should be better.


Juergen