2022-04-08 07:59:01

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: remove cpu compatible "arm,armv8" for s4

On 08/04/2022 09:09, Xianwei Zhao wrote:
> Amlogic s4 device is already applied, but cpu compatible 'arm,armv8'
> is only valid for software models, so we remove it.
>
> Fixes: ac4dfd0d1d35 ("arm64: dts: add support for S4 based Amlogic AQ222")
> Signed-off-by: Xianwei Zhao <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index bf9ae1e1016b..480afa2cc61f 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> @@ -13,28 +13,28 @@ cpus {
>
> cpu0: cpu@0 {
> device_type = "cpu";
> - compatible = "arm,cortex-a35","arm,armv8";
> + compatible = "arm,cortex-a35";
> reg = <0x0 0x0>;
> enable-method = "psci";
> };
>
> cpu1: cpu@1 {
> device_type = "cpu";
> - compatible = "arm,cortex-a35","arm,armv8";
> + compatible = "arm,cortex-a35";
> reg = <0x0 0x1>;
> enable-method = "psci";
> };
>
> cpu2: cpu@2 {
> device_type = "cpu";
> - compatible = "arm,cortex-a35","arm,armv8";
> + compatible = "arm,cortex-a35";
> reg = <0x0 0x2>;
> enable-method = "psci";
> };
>
> cpu3: cpu@3 {
> device_type = "cpu";
> - compatible = "arm,cortex-a35","arm,armv8";
> + compatible = "arm,cortex-a35";
> reg = <0x0 0x3>;
> enable-method = "psci";
> };
>
> base-commit: fd86d85401c2049f652293877c0f7e6e5afc3bbc

Reviewed-by: Neil Armstrong <[email protected]>