2021-02-25 03:06:43

by Rafael J. Wysocki

Subject: [PATCH v1] ACPI: processor: idle: Drop extra prefix from pr_notice()

From: Rafael J. Wysocki <[email protected]>

Drop "ACPI: " from the pr_noitice() instance in
acpi_processor_cstate_first_run_checks(), because pr_fmt() causes
that prefix to be added to the message already.

Reported-by: Hanjun Guo <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/acpi/processor_idle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/acpi/processor_idle.c
===================================================================
--- linux-pm.orig/drivers/acpi/processor_idle.c
+++ linux-pm/drivers/acpi/processor_idle.c
@@ -780,8 +780,8 @@ static inline void acpi_processor_cstate
dmi_check_system(processor_power_dmi_table);
max_cstate = acpi_processor_cstate_check(max_cstate);
if (max_cstate < ACPI_C_STATES_MAX)
- pr_notice("ACPI: processor limited to max C-state %d\n",
- max_cstate);
+ pr_notice("processor limited to max C-state %d\n", max_cstate);
+
first_run++;

if (nocst)

2021-02-25 14:23:29

by Hanjun Guo

Subject: Re: [PATCH v1] ACPI: processor: idle: Drop extra prefix from pr_notice()

On 2021/2/25 2:37, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> Drop "ACPI: " from the pr_noitice() instance in
> acpi_processor_cstate_first_run_checks(), because pr_fmt() causes
> that prefix to be added to the message already.
>
> Reported-by: Hanjun Guo <[email protected]>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---
> drivers/acpi/processor_idle.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/acpi/processor_idle.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/processor_idle.c
> +++ linux-pm/drivers/acpi/processor_idle.c
> @@ -780,8 +780,8 @@ static inline void acpi_processor_cstate
> dmi_check_system(processor_power_dmi_table);
> max_cstate = acpi_processor_cstate_check(max_cstate);
> if (max_cstate < ACPI_C_STATES_MAX)
> - pr_notice("ACPI: processor limited to max C-state %d\n",
> - max_cstate);
> + pr_notice("processor limited to max C-state %d\n", max_cstate);
> +
> first_run++;
>
> if (nocst)

Reviewed-by: Hanjun Guo <[email protected]>

Thanks
Hanjun