2022-04-09 10:48:51

by Manivannan Sadhasivam

Subject: [PATCH v2] bus: mhi: host: pci_generic: Flush recovery worker during freeze

It is possible that the recovery work might be running while the freeze
gets executed (during hibernation etc.,). Currently, we don't powerdown
the stack if it is not up but if the recovery work completes after freeze,
then the device will be up afterwards. This will not be a sane situation.

So let's flush the recovery worker before trying to powerdown the device.

Cc: [email protected]
Fixes: 5f0c2ee1fe8d ("bus: mhi: pci-generic: Fix hibernation")
Reported-by: Bhaumik Vasav Bhatt <[email protected]>
Signed-off-by: Manivannan Sadhasivam <[email protected]>
---

Changes in v2:

* Switched to flush_work() as the workqueue used is global one.

drivers/bus/mhi/host/pci_generic.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index ef85dbfb3216..541ced27d941 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -1060,6 +1060,7 @@ static int __maybe_unused mhi_pci_freeze(struct device *dev)
* the intermediate restore kernel reinitializes MHI device with new
* context.
*/
+ flush_work(&mhi_pdev->recovery_work);
if (test_and_clear_bit(MHI_PCI_DEV_STARTED, &mhi_pdev->status)) {
mhi_power_down(mhi_cntrl, true);
mhi_unprepare_after_power_down(mhi_cntrl);
--
2.25.1

2022-04-10 00:53:04

by Bhaumik Vasav Bhatt

Subject: Re: [PATCH v2] bus: mhi: host: pci_generic: Flush recovery worker during freeze

On 4/8/2022 8:00 AM, Manivannan Sadhasivam wrote:
> It is possible that the recovery work might be running while the freeze
> gets executed (during hibernation etc.,). Currently, we don't powerdown
> the stack if it is not up but if the recovery work completes after freeze,
> then the device will be up afterwards. This will not be a sane situation.
>
> So let's flush the recovery worker before trying to powerdown the device.
>
> Cc: [email protected]
> Fixes: 5f0c2ee1fe8d ("bus: mhi: pci-generic: Fix hibernation")
> Reported-by: Bhaumik Vasav Bhatt <[email protected]>
> Signed-off-by: Manivannan Sadhasivam <[email protected]>
> ---
Reviewed-by: Bhaumik Vasav Bhatt <[email protected]>
> Changes in v2:
>
> * Switched to flush_work() as the workqueue used is global one.
>
> drivers/bus/mhi/host/pci_generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index ef85dbfb3216..541ced27d941 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -1060,6 +1060,7 @@ static int __maybe_unused mhi_pci_freeze(struct device *dev)
> * the intermediate restore kernel reinitializes MHI device with new
> * context.
> */
> + flush_work(&mhi_pdev->recovery_work);
> if (test_and_clear_bit(MHI_PCI_DEV_STARTED, &mhi_pdev->status)) {
> mhi_power_down(mhi_cntrl, true);
> mhi_unprepare_after_power_down(mhi_cntrl);

2022-04-11 09:57:18

by Manivannan Sadhasivam

Subject: Re: [PATCH v2] bus: mhi: host: pci_generic: Flush recovery worker during freeze

On Fri, Apr 08, 2022 at 08:30:39PM +0530, Manivannan Sadhasivam wrote:
> It is possible that the recovery work might be running while the freeze
> gets executed (during hibernation etc.,). Currently, we don't powerdown
> the stack if it is not up but if the recovery work completes after freeze,
> then the device will be up afterwards. This will not be a sane situation.
>
> So let's flush the recovery worker before trying to powerdown the device.
>
> Cc: [email protected]
> Fixes: 5f0c2ee1fe8d ("bus: mhi: pci-generic: Fix hibernation")
> Reported-by: Bhaumik Vasav Bhatt <[email protected]>
> Signed-off-by: Manivannan Sadhasivam <[email protected]>

Applied to mhi-next!

Thanks,
Mani

> ---
>
> Changes in v2:
>
> * Switched to flush_work() as the workqueue used is global one.
>
> drivers/bus/mhi/host/pci_generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index ef85dbfb3216..541ced27d941 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -1060,6 +1060,7 @@ static int __maybe_unused mhi_pci_freeze(struct device *dev)
> * the intermediate restore kernel reinitializes MHI device with new
> * context.
> */
> + flush_work(&mhi_pdev->recovery_work);
> if (test_and_clear_bit(MHI_PCI_DEV_STARTED, &mhi_pdev->status)) {
> mhi_power_down(mhi_cntrl, true);
> mhi_unprepare_after_power_down(mhi_cntrl);
> --
> 2.25.1
>