Subject: [PATCH v4 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings

From: Arthur Becker <[email protected]>

Device tree bindings for the vishay VEML6040 RGBW light sensor iio
driver

Signed-off-by: Arthur Becker <[email protected]>
---
V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
along with v2 of the driver but not in a set)
V3 -> V4: Combined dt-binding with veml6075 as they are basically the
same
---
Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
index 91c318746bf3..ecf2339e02f6 100644
--- a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
+++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
@@ -4,14 +4,19 @@
$id: http://devicetree.org/schemas/iio/light/vishay,veml6075.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

-title: Vishay VEML6075 UVA and UVB sensor
+title: Vishay VEML6075 UVA/B and VEML6040 RGBW sensors

maintainers:
- Javier Carrasco <[email protected]>

+description:
+ VEML6040 datasheet at https://www.vishay.com/docs/84276/veml6040.pdf
+
properties:
compatible:
- const: vishay,veml6075
+ enum:
+ - vishay,veml6040
+ - vishay,veml6075

reg:
maxItems: 1

--
2.34.1




2024-06-04 09:03:29

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings

On 04/06/2024 10:01, Arthur Becker via B4 Relay wrote:
> From: Arthur Becker <[email protected]>
>
> Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> driver
>
> Signed-off-by: Arthur Becker <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

If there is any resend:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Best regards,
Krzysztof