2020-06-28 22:07:39

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the block tree

Hi all,

In commit

8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")

Fixes tag

Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")

has these problem(s):

- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-06-29 21:22:00

by Jens Axboe

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the block tree

On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> On 29/06/2020 01:05, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>> 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>>
>> Fixes tag
>>
>> Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")
>
> Jens, could you please fix this up after me?
> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a

I don't think that's a grave enough concern to rebase, it's just "missing" a
single digit of the sha.

--
Jens Axboe

2020-06-29 21:23:38

by Pavel Begunkov

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the block tree

On 29/06/2020 01:05, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>
> Fixes tag
>
> Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")

Jens, could you please fix this up after me?
full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a

> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>

--
Pavel Begunkov

2020-06-29 22:37:24

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the block tree

Hi all,

On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe <[email protected]> wrote:
>
> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> > On 29/06/2020 01:05, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> In commit
> >>
> >> 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
> >>
> >> Fixes tag
> >>
> >> Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")
> >
> > Jens, could you please fix this up after me?
> > full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a
>
> I don't think that's a grave enough concern to rebase, it's just "missing" a
> single digit of the sha.

Yeah, its more of a "please fix your git config". :-)

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-06-29 22:49:01

by Jens Axboe

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the block tree

On 6/29/20 4:36 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe <[email protected]> wrote:
>>
>> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
>>> On 29/06/2020 01:05, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>> 8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>>>>
>>>> Fixes tag
>>>>
>>>> Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")
>>>
>>> Jens, could you please fix this up after me?
>>> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a
>>
>> I don't think that's a grave enough concern to rebase, it's just "missing" a
>> single digit of the sha.
>
> Yeah, its more of a "please fix your git config". :-)

Agree! But I'm guessing that Pavel did this manually, which I end up
doing a lot too... And then mistakes happen.

--
Jens Axboe