2020-03-26 16:13:05

by Neil Armstrong

Subject: [PATCH] dt-bindings: usb: dwc2: fix bindings for amlogic,meson-gxbb-usb

The amlogic,meson-gxbb-usb compatible needs snps,dwc2 aswell like other
Amlogic SoC.

Fixes: f3ca745d8a0e ("dt-bindings: usb: Convert DWC2 bindings to json-schema")
Signed-off-by: Neil Armstrong <[email protected]>
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 71cf7ba32237..b7b9ddcbc637 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -49,7 +49,9 @@ properties:
- items:
- const: amlogic,meson8b-usb
- const: snps,dwc2
- - const: amlogic,meson-gxbb-usb
+ - items:
+ - const: amlogic,meson-gxbb-usb
+ - const: snps,dwc2
- items:
- const: amlogic,meson-g12a-usb
- const: snps,dwc2
--
2.22.0

2020-03-26 16:29:26

by Benjamin GAIGNARD

Subject: Re: [PATCH] dt-bindings: usb: dwc2: fix bindings for amlogic,meson-gxbb-usb

On 3/26/20 5:10 PM, Neil Armstrong wrote:
> The amlogic,meson-gxbb-usb compatible needs snps,dwc2 aswell like other
> Amlogic SoC.
>
> Fixes: f3ca745d8a0e ("dt-bindings: usb: Convert DWC2 bindings to json-schema")
> Signed-off-by: Neil Armstrong <[email protected]>
Reviewed-by: Benjamin Gaignard <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 71cf7ba32237..b7b9ddcbc637 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -49,7 +49,9 @@ properties:
> - items:
> - const: amlogic,meson8b-usb
> - const: snps,dwc2
> - - const: amlogic,meson-gxbb-usb
> + - items:
> + - const: amlogic,meson-gxbb-usb
> + - const: snps,dwc2
> - items:
> - const: amlogic,meson-g12a-usb
> - const: snps,dwc2

2020-03-26 17:58:24

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: usb: dwc2: fix bindings for amlogic,meson-gxbb-usb

On Thu, Mar 26, 2020 at 10:10 AM Neil Armstrong <[email protected]> wrote:
>
> The amlogic,meson-gxbb-usb compatible needs snps,dwc2 aswell like other
> Amlogic SoC.
>
> Fixes: f3ca745d8a0e ("dt-bindings: usb: Convert DWC2 bindings to json-schema")
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 71cf7ba32237..b7b9ddcbc637 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -49,7 +49,9 @@ properties:
> - items:
> - const: amlogic,meson8b-usb
> - const: snps,dwc2
> - - const: amlogic,meson-gxbb-usb
> + - items:
> + - const: amlogic,meson-gxbb-usb
> + - const: snps,dwc2
> - items:
> - const: amlogic,meson-g12a-usb

Perhaps combine at least all the amlogic ones to a single entry.

> - const: snps,dwc2
> --
> 2.22.0
>