2004-10-04 05:51:53

by Steve Moskovchenko

[permalink] [raw]
Subject: [PATCH] RadeonFB ACPI S3 patch fixed to not break S4. 2.6.8.1, 2.6.7

This applies to the patch written by Ole Rohne, ole.rohne_AT_cern.ch
This applies to Radeon Mobility cards (mine is M9000 but it could work
for others) on certain laptops that don't reinitialize the video BIOS
upon resume (Mine is a Dell Insipron 600m but there are others).

This patch reinitializes the Radeon BIOS upon resume from an ACPI sleep
state other than S4.

The original patch reinitialized the video bios from any ACPI resume,
but this broke suspending to S4. The machine would begin to suspend,
then the display would go dark and the system would become unresponsive.

I added an if statement to the part that patches radeon_pm.c so that it
would NOT try to reinitialize the video BIOS if the machine is entering
S4. This worked.

Given how much aggrivation this has given me, I figure submitting the
new patch would be nice.



--
Steve M <[email protected]>


Attachments:
README (479.00 B)
patch-radeonfb (4.13 kB)
Download all attachments

2004-10-06 12:35:23

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] RadeonFB ACPI S3 patch fixed to not break S4. 2.6.8.1, 2.6.7

Hi!

> This applies to the patch written by Ole Rohne, ole.rohne_AT_cern.ch
> This applies to Radeon Mobility cards (mine is M9000 but it could work
> for others) on certain laptops that don't reinitialize the video BIOS
> upon resume (Mine is a Dell Insipron 600m but there are others).
>
> This patch reinitializes the Radeon BIOS upon resume from an ACPI sleep
> state other than S4.
>
> The original patch reinitialized the video bios from any ACPI resume,
> but this broke suspending to S4. The machine would begin to suspend,
> then the display would go dark and the system would become unresponsive.
>
> I added an if statement to the part that patches radeon_pm.c so that it
> would NOT try to reinitialize the video BIOS if the machine is entering
> S4. This worked.

Ok.

> Given how much aggrivation this has given me, I figure submitting the
> new patch would be nice.

It needs to follow kernel coding style (see acpi sleep.c). On what
machine did you test it? I have machine (Arima) with radeon but ole's
patches did not work for me, I'll probably test this one too.

Pavel


--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

2004-10-07 13:55:01

by Stefan Schweizer

[permalink] [raw]
Subject: Re: [PATCH] RadeonFB ACPI S3 patch fixed to not break S4. 2.6.8.1, 2.6.7

Your patch has the same problem as Oles for me. It stops after
"radeonfb: resumed !". If I press a key then, it proceedes.

Stopping tasks: ==========================|
radeonfb: suspending to state: 3...
hwsleep-0312 [245] acpi_enter_sleep_state: Entering sleep state [S3]
Back to C!
PCI: Found IRQ 5 for device 0000:00:1f.2
PCI: Setting latency timer of device 0000:00:1f.2 to 64
PCI: Found IRQ 11 for device 0000:00:1f.4
PCI: Setting latency timer of device 0000:00:1f.4 to 64
PCI: Found IRQ 11 for device 0000:00:1f.5
PCI: Sharing IRQ 11 with 0000:00:1f.3
PCI: Sharing IRQ 11 with 0000:00:1f.6
PCI: Sharing IRQ 11 with 0000:02:00.1
PCI: Setting latency timer of device 0000:00:1f.5 to 64
radeonfb: resumed !
e100: eth0: e100_watchdog: link up, 100Mbps, full-duplex
Restarting tasks... done


Attachments:
(No filename) (794.00 B)
.config (29.18 kB)
Download all attachments

2004-10-07 15:40:37

by Stefan Schweizer

[permalink] [raw]
Subject: Re: [PATCH] RadeonFB ACPI S3 patch fixed to not break S4. 2.6.8.1, 2.6.7

Hi,
Nice that you also have the same problem.
Do you have any clue what driver is causing this? Its really annoying
for me with S3.
Perhaps I could figure it out with more verbose messages, any I dea
how to get them?

Stefan

On Thu, 07 Oct 2004 03:42:15 -0400, Steve M <stevenm <aaatt> umd.edu> wrote:
> Hello.
> Mine does this occasionally. I do not really understand why. Some say it
> is because some things are missing interrupts, and I will try some more
> rigorous mudile unloading and modulizing of things compiled in. Having
> to press a key doesn't bother me that much, because with this modified
> patch Suspend-to-Disk works again. I will play around with it further,
> though.
>
> On Thu, 2004-10-07 at 15:52 +0200, Stefan Schweizer wrote:
> > Your patch has the same problem as Oles for me. It stops after
> > "radeonfb: resumed !". If I press a key then, it proceedes.