2019-04-06 13:33:49

by Souptick Joarder

Subject: [PATCH] perf: Remove duplicate headers

Removed duplicate headers which are included twice.

Signed-off-by: Souptick Joarder <[email protected]>
---
tools/perf/util/data.c | 1 -
tools/perf/util/get_current_dir_name.c | 1 -
tools/perf/util/stat-display.c | 1 -
3 files changed, 3 deletions(-)

diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
index 6a64f71..509a41e 100644
--- a/tools/perf/util/data.c
+++ b/tools/perf/util/data.c
@@ -8,7 +8,6 @@
#include <unistd.h>
#include <string.h>
#include <asm/bug.h>
-#include <sys/types.h>
#include <dirent.h>

#include "data.h"
diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
index 267aa60..ebb80cd 100644
--- a/tools/perf/util/get_current_dir_name.c
+++ b/tools/perf/util/get_current_dir_name.c
@@ -5,7 +5,6 @@
#include "util.h"
#include <unistd.h>
#include <stdlib.h>
-#include <stdlib.h>

/* Android's 'bionic' library, for one, doesn't have this */

diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 6d043c7..7b3a16c 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -12,7 +12,6 @@
#include "string2.h"
#include "sane_ctype.h"
#include "cgroup.h"
-#include <math.h>
#include <api/fs/fs.h>

#define CNTR_NOT_SUPPORTED "<not supported>"
--
1.9.1

2019-04-06 18:51:06

by Mukesh Ojha

Subject: Re: [PATCH] perf: Remove duplicate headers

On 4/6/2019 7:06 PM, Souptick Joarder wrote:
> Removed duplicate headers which are included twice.
> Signed-off-by: Souptick Joarder <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> tools/perf/util/data.c | 1 -
> tools/perf/util/get_current_dir_name.c | 1 -
> tools/perf/util/stat-display.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index 6a64f71..509a41e 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -8,7 +8,6 @@
> #include <unistd.h>
> #include <string.h>
> #include <asm/bug.h>
> -#include <sys/types.h>
> #include <dirent.h>
>
> #include "data.h"
> diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> index 267aa60..ebb80cd 100644
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -5,7 +5,6 @@
> #include "util.h"
> #include <unistd.h>
> #include <stdlib.h>
> -#include <stdlib.h>
>
> /* Android's 'bionic' library, for one, doesn't have this */
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 6d043c7..7b3a16c 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -12,7 +12,6 @@
> #include "string2.h"
> #include "sane_ctype.h"
> #include "cgroup.h"
> -#include <math.h>
> #include <api/fs/fs.h>
>
> #define CNTR_NOT_SUPPORTED "<not supported>"

2019-04-16 11:55:26

by Souptick Joarder

Subject: Re: [PATCH] perf: Remove duplicate headers

On Sun, Apr 7, 2019 at 12:20 AM Mukesh Ojha <[email protected]> wrote:
>
>
> On 4/6/2019 7:06 PM, Souptick Joarder wrote:
> > Removed duplicate headers which are included twice.
> > Signed-off-by: Souptick Joarder <[email protected]>
> Reviewed-by: Mukesh Ojha <[email protected]>

If no further comment, can we get this patch in queue for 5.2 ?

>
> Cheers,
> -Mukesh
>
> > ---
> > tools/perf/util/data.c | 1 -
> > tools/perf/util/get_current_dir_name.c | 1 -
> > tools/perf/util/stat-display.c | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> > index 6a64f71..509a41e 100644
> > --- a/tools/perf/util/data.c
> > +++ b/tools/perf/util/data.c
> > @@ -8,7 +8,6 @@
> > #include <unistd.h>
> > #include <string.h>
> > #include <asm/bug.h>
> > -#include <sys/types.h>
> > #include <dirent.h>
> >
> > #include "data.h"
> > diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> > index 267aa60..ebb80cd 100644
> > --- a/tools/perf/util/get_current_dir_name.c
> > +++ b/tools/perf/util/get_current_dir_name.c
> > @@ -5,7 +5,6 @@
> > #include "util.h"
> > #include <unistd.h>
> > #include <stdlib.h>
> > -#include <stdlib.h>
> >
> > /* Android's 'bionic' library, for one, doesn't have this */
> >
> > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> > index 6d043c7..7b3a16c 100644
> > --- a/tools/perf/util/stat-display.c
> > +++ b/tools/perf/util/stat-display.c
> > @@ -12,7 +12,6 @@
> > #include "string2.h"
> > #include "sane_ctype.h"
> > #include "cgroup.h"
> > -#include <math.h>
> > #include <api/fs/fs.h>
> >
> > #define CNTR_NOT_SUPPORTED "<not supported>"

2019-05-11 07:35:35

by Souptick Joarder

Subject: Re: [PATCH] perf: Remove duplicate headers

On Tue, Apr 16, 2019 at 5:27 PM Souptick Joarder <[email protected]> wrote:
>
> On Sun, Apr 7, 2019 at 12:20 AM Mukesh Ojha <[email protected]> wrote:
> >
> >
> > On 4/6/2019 7:06 PM, Souptick Joarder wrote:
> > > Removed duplicate headers which are included twice.
> > > Signed-off-by: Souptick Joarder <[email protected]>
> > Reviewed-by: Mukesh Ojha <[email protected]>
>
> If no further comment, can we get this patch in queue for 5.2 ?

Can we get this in queue for 5.2 ?

>
> >
> > Cheers,
> > -Mukesh
> >
> > > ---
> > > tools/perf/util/data.c | 1 -
> > > tools/perf/util/get_current_dir_name.c | 1 -
> > > tools/perf/util/stat-display.c | 1 -
> > > 3 files changed, 3 deletions(-)
> > >
> > > diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> > > index 6a64f71..509a41e 100644
> > > --- a/tools/perf/util/data.c
> > > +++ b/tools/perf/util/data.c
> > > @@ -8,7 +8,6 @@
> > > #include <unistd.h>
> > > #include <string.h>
> > > #include <asm/bug.h>
> > > -#include <sys/types.h>
> > > #include <dirent.h>
> > >
> > > #include "data.h"
> > > diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> > > index 267aa60..ebb80cd 100644
> > > --- a/tools/perf/util/get_current_dir_name.c
> > > +++ b/tools/perf/util/get_current_dir_name.c
> > > @@ -5,7 +5,6 @@
> > > #include "util.h"
> > > #include <unistd.h>
> > > #include <stdlib.h>
> > > -#include <stdlib.h>
> > >
> > > /* Android's 'bionic' library, for one, doesn't have this */
> > >
> > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> > > index 6d043c7..7b3a16c 100644
> > > --- a/tools/perf/util/stat-display.c
> > > +++ b/tools/perf/util/stat-display.c
> > > @@ -12,7 +12,6 @@
> > > #include "string2.h"
> > > #include "sane_ctype.h"
> > > #include "cgroup.h"
> > > -#include <math.h>
> > > #include <api/fs/fs.h>
> > >
> > > #define CNTR_NOT_SUPPORTED "<not supported>"