2024-05-05 16:52:33

by Frank Wunderlich

Subject: [RFC v1 3/5] dt-bindings: net: mediatek,net: add reset-cells

From: Frank Wunderlich <[email protected]>

Add missing binding for property used in mt7986a.dtsi.

Signed-off-by: Frank Wunderlich <[email protected]>
---
Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index e74502a0afe8..5214927c0fe8 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -101,6 +101,9 @@ properties:
"#address-cells":
const: 1

+ "#reset-cells":
+ const: 1
+
"#size-cells":
const: 0

--
2.34.1

2024-05-06 08:19:37

by Krzysztof Kozlowski

Subject: Re: [RFC v1 3/5] dt-bindings: net: mediatek,net: add reset-cells

On 05/05/2024 18:45, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> Add missing binding for property used in mt7986a.dtsi.
>

Again, no, it is not missing, if the device is not reset controller.

Provide explanation why this is suitable in the binding. IOW, why DTS is
right, but binding is wrong.

Best regards,
Krzysztof

2024-05-07 19:37:48

by Rob Herring (Arm)

Subject: Re: [RFC v1 3/5] dt-bindings: net: mediatek,net: add reset-cells

On Sun, May 05, 2024 at 06:45:47PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> Add missing binding for property used in mt7986a.dtsi.
>
> Signed-off-by: Frank Wunderlich <[email protected]>
> ---
> Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> index e74502a0afe8..5214927c0fe8 100644
> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> @@ -101,6 +101,9 @@ properties:
> "#address-cells":
> const: 1
>
> + "#reset-cells":
> + const: 1

Also fixed already.

Rob