2023-07-25 10:51:57

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] media: dt-bindings: drop unneeded status from examples

Example DTS should not have 'status' property.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml | 1 -
Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml | 1 -
2 files changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
index 369c48fd9bf9..a6b73498bc21 100644
--- a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
+++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
@@ -53,6 +53,5 @@ examples:
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&tegra_car TEGRA124_CLK_CEC>;
clock-names = "cec";
- status = "disabled";
hdmi-phandle = <&hdmi>;
};
diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
index 19a39d753aad..b68141264c0e 100644
--- a/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
@@ -143,7 +143,6 @@ examples:
mipid02: csi2rx@14 {
compatible = "st,st-mipid02";
reg = <0x14>;
- status = "okay";
clocks = <&clk_ext_camera_12>;
clock-names = "xclk";
VDDE-supply = <&vdd>;
--
2.34.1



2023-07-25 11:52:36

by Benjamin Mugnier

[permalink] [raw]
Subject: Re: [PATCH] media: dt-bindings: drop unneeded status from examples

Hi Krzysztof,

Thank you for your patch.

For the st-mipid02 :
Reviewed-By: Benjamin Mugnier <[email protected]>

On 7/25/23 12:16, Krzysztof Kozlowski wrote:
> Example DTS should not have 'status' property.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml | 1 -
> Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
> index 369c48fd9bf9..a6b73498bc21 100644
> --- a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
> +++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
> @@ -53,6 +53,5 @@ examples:
> interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&tegra_car TEGRA124_CLK_CEC>;
> clock-names = "cec";
> - status = "disabled";
> hdmi-phandle = <&hdmi>;
> };
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
> index 19a39d753aad..b68141264c0e 100644
> --- a/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
> @@ -143,7 +143,6 @@ examples:
> mipid02: csi2rx@14 {
> compatible = "st,st-mipid02";
> reg = <0x14>;
> - status = "okay";
> clocks = <&clk_ext_camera_12>;
> clock-names = "xclk";
> VDDE-supply = <&vdd>;

--
Regards,

Benjamin

2023-07-25 19:14:39

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] media: dt-bindings: drop unneeded status from examples

On Tue, Jul 25, 2023 at 12:16:25PM +0200, Krzysztof Kozlowski wrote:
> Example DTS should not have 'status' property.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

Attachments:
(No filename) (269.00 B)
 signature.asc (235.00 B)
 Download all attachments

2023-07-26 07:15:54

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] media: dt-bindings: drop unneeded status from examples

On 25/07/2023 12:55, Benjamin Mugnier wrote:
> Hi Krzysztof,
>
> Thank you for your patch.
>
> For the st-mipid02 :
> Reviewed-By: Benjamin Mugnier <[email protected]>

I don't think we have half-reviews. There are half-acks, but not reviews.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L542

Best regards,
Krzysztof


2023-07-31 10:55:41

by Benjamin Mugnier

[permalink] [raw]
Subject: Re: [PATCH] media: dt-bindings: drop unneeded status from examples

On 7/26/23 08:33, Krzysztof Kozlowski wrote:
> On 25/07/2023 12:55, Benjamin Mugnier wrote:
>> Hi Krzysztof,
>>
>> Thank you for your patch.
>>
>> For the st-mipid02 :
>> Reviewed-By: Benjamin Mugnier <[email protected]>
>
> I don't think we have half-reviews. There are half-acks, but not reviews.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L542
>
> Best regards,
> Krzysztof
>

I was not aware of this, thanks for pointing it to me.

For the st-mipid02 :
Acked-By: Benjamin Mugnier <[email protected]>

--
Regards,

Benjamin