2021-07-15 16:49:23

by Linus Walleij

Subject: [PATCH] extcon: max3355: Drop unused include

This driver includes the legacy <linux/gpio.h> header but
does not use it. Drop this include.

Cc: Sergei Shtylyov <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
---
drivers/extcon/extcon-max3355.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
index fa01926c09f1..d7795607f693 100644
--- a/drivers/extcon/extcon-max3355.c
+++ b/drivers/extcon/extcon-max3355.c
@@ -7,7 +7,6 @@
*/

#include <linux/extcon-provider.h>
-#include <linux/gpio.h>
#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/module.h>
--
2.31.1

2021-07-23 05:32:11

by Chanwoo Choi

Subject: Re: [PATCH] extcon: max3355: Drop unused include

On 7/16/21 12:26 AM, Linus Walleij wrote:
> This driver includes the legacy <linux/gpio.h> header but
> does not use it. Drop this include.
>
> Cc: Sergei Shtylyov <[email protected]>
> Signed-off-by: Linus Walleij <[email protected]>
> ---
> drivers/extcon/extcon-max3355.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
> index fa01926c09f1..d7795607f693 100644
> --- a/drivers/extcon/extcon-max3355.c
> +++ b/drivers/extcon/extcon-max3355.c
> @@ -7,7 +7,6 @@
> */
>
> #include <linux/extcon-provider.h>
> -#include <linux/gpio.h>
> #include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/module.h>
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics