From: Björn Töpel <[email protected]>
A misspelled invokation of git-grep, revealed that
smp_mb__after_spinlock() was misspelled in explaination.txt.
Add missing "_" to smp_mb__after_spinlock().
Fixes: 1c27b644c0fd ("Automate memory-barriers.txt; provide Linux-kernel memory model")
Signed-off-by: Björn Töpel <[email protected]>
---
tools/memory-model/Documentation/explanation.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
index f9d610d5a1a4..5d72f3112e56 100644
--- a/tools/memory-model/Documentation/explanation.txt
+++ b/tools/memory-model/Documentation/explanation.txt
@@ -2510,7 +2510,7 @@ they behave as follows:
smp_mb__after_atomic() orders po-earlier atomic updates and
the events preceding them against all po-later events;
- smp_mb_after_spinlock() orders po-earlier lock acquisition
+ smp_mb__after_spinlock() orders po-earlier lock acquisition
events and the events preceding them against all po-later
events.
base-commit: 7f58c0fb9238abaa3997185ceec319201b6f5a94
--
2.27.0
On Fri, Mar 05, 2021 at 11:28:23AM +0100, Bj?rn T?pel wrote:
> From: Bj?rn T?pel <[email protected]>
>
> A misspelled invokation of git-grep, revealed that
> smp_mb__after_spinlock() was misspelled in explaination.txt.
>
> Add missing "_" to smp_mb__after_spinlock().
>
> Fixes: 1c27b644c0fd ("Automate memory-barriers.txt; provide Linux-kernel memory model")
> Signed-off-by: Bj?rn T?pel <[email protected]>
Good catch! Applied, thank you!
Thanx, Paul
> ---
> tools/memory-model/Documentation/explanation.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
> index f9d610d5a1a4..5d72f3112e56 100644
> --- a/tools/memory-model/Documentation/explanation.txt
> +++ b/tools/memory-model/Documentation/explanation.txt
> @@ -2510,7 +2510,7 @@ they behave as follows:
> smp_mb__after_atomic() orders po-earlier atomic updates and
> the events preceding them against all po-later events;
>
> - smp_mb_after_spinlock() orders po-earlier lock acquisition
> + smp_mb__after_spinlock() orders po-earlier lock acquisition
> events and the events preceding them against all po-later
> events.
>
>
> base-commit: 7f58c0fb9238abaa3997185ceec319201b6f5a94
> --
> 2.27.0
>
On Fri, Mar 05, 2021 at 11:28:23AM +0100, Bj?rn T?pel wrote:
> From: Bj?rn T?pel <[email protected]>
>
> A misspelled invokation of git-grep, revealed that
-------------------^
Smetimes my brain is a little slow... Do you confirm that this is a
joke?
Alan
On 2021-03-05 16:36, Alan Stern wrote:
> On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
>> From: Björn Töpel <[email protected]>
>>
>> A misspelled invokation of git-grep, revealed that
> -------------------^
>
> Smetimes my brain is a little slow... Do you confirm that this is a
> joke?
>
I wish, Alan. I wish.
Looks like I can only spel function names correctly.
Have a nice weekend!
Björn
> Alan
>
On Fri, Mar 05, 2021 at 04:41:49PM +0100, Bj?rn T?pel wrote:
> On 2021-03-05 16:36, Alan Stern wrote:
> > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Bj?rn T?pel wrote:
> > > From: Bj?rn T?pel <[email protected]>
> > >
> > > A misspelled invokation of git-grep, revealed that
> > -------------------^
> >
> > Smetimes my brain is a little slow... Do you confirm that this is a
> > joke?
> >
>
> I wish, Alan. I wish.
>
> Looks like I can only spel function names correctly.
Heh! I missed that one completely. Please see below for a wortschmied
commit.
Thanx, Paul
------------------------------------------------------------------------
commit 1c737ce34715db9431f6b034f92dbf09d954126d
Author: Bj?rn T?pel <[email protected]>
Date: Fri Mar 5 11:28:23 2021 +0100
tools/memory-model: Fix smp_mb__after_spinlock() spelling
A misspelled git-grep regex revealed that smp_mb__after_spinlock()
was misspelled in explanation.txt.
This commit adds the missing "_" to smp_mb__after_spinlock().
Fixes: 1c27b644c0fd ("Automate memory-barriers.txt; provide Linux-kernel memory model")
[ paulmck: Apply Alan Stern commit-log feedback. ]
Signed-off-by: Bj?rn T?pel <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
index f9d610d..5d72f31 100644
--- a/tools/memory-model/Documentation/explanation.txt
+++ b/tools/memory-model/Documentation/explanation.txt
@@ -2510,7 +2510,7 @@ they behave as follows:
smp_mb__after_atomic() orders po-earlier atomic updates and
the events preceding them against all po-later events;
- smp_mb_after_spinlock() orders po-earlier lock acquisition
+ smp_mb__after_spinlock() orders po-earlier lock acquisition
events and the events preceding them against all po-later
events.
On Fri, Mar 05, 2021 at 10:26:50AM -0800, Paul E. McKenney wrote:
> On Fri, Mar 05, 2021 at 04:41:49PM +0100, Bj?rn T?pel wrote:
> > On 2021-03-05 16:36, Alan Stern wrote:
> > > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Bj?rn T?pel wrote:
> > > > From: Bj?rn T?pel <[email protected]>
> > > >
> > > > A misspelled invokation of git-grep, revealed that
> > > -------------------^
> > >
> > > Smetimes my brain is a little slow... Do you confirm that this is a
> > > joke?
> > >
> >
> > I wish, Alan. I wish.
> >
> > Looks like I can only spel function names correctly.
>
> Heh! I missed that one completely. Please see below for a wortschmied
> commit.
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit 1c737ce34715db9431f6b034f92dbf09d954126d
> Author: Bj?rn T?pel <[email protected]>
> Date: Fri Mar 5 11:28:23 2021 +0100
>
> tools/memory-model: Fix smp_mb__after_spinlock() spelling
>
> A misspelled git-grep regex revealed that smp_mb__after_spinlock()
> was misspelled in explanation.txt.
>
> This commit adds the missing "_" to smp_mb__after_spinlock().
Strictly speaking, the commit adds a missing "_" to
smp_mb_after_spinlock(). If it added anything to
smp_mb__after_spinlock(), the result would be incorrect.
How about just:
A misspelled git-grep regex revealed that smp_mb__after_spinlock()
was misspelled in explanation.txt. This commit adds the missing "_".
Alan
On Fri, Mar 05, 2021 at 01:59:24PM -0500, Alan Stern wrote:
> On Fri, Mar 05, 2021 at 10:26:50AM -0800, Paul E. McKenney wrote:
> > On Fri, Mar 05, 2021 at 04:41:49PM +0100, Bj?rn T?pel wrote:
> > > On 2021-03-05 16:36, Alan Stern wrote:
> > > > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Bj?rn T?pel wrote:
> > > > > From: Bj?rn T?pel <[email protected]>
> > > > >
> > > > > A misspelled invokation of git-grep, revealed that
> > > > -------------------^
> > > >
> > > > Smetimes my brain is a little slow... Do you confirm that this is a
> > > > joke?
> > > >
> > >
> > > I wish, Alan. I wish.
> > >
> > > Looks like I can only spel function names correctly.
> >
> > Heh! I missed that one completely. Please see below for a wortschmied
> > commit.
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > commit 1c737ce34715db9431f6b034f92dbf09d954126d
> > Author: Bj?rn T?pel <[email protected]>
> > Date: Fri Mar 5 11:28:23 2021 +0100
> >
> > tools/memory-model: Fix smp_mb__after_spinlock() spelling
> >
> > A misspelled git-grep regex revealed that smp_mb__after_spinlock()
> > was misspelled in explanation.txt.
> >
> > This commit adds the missing "_" to smp_mb__after_spinlock().
>
> Strictly speaking, the commit adds a missing "_" to
> smp_mb_after_spinlock(). If it added anything to
> smp_mb__after_spinlock(), the result would be incorrect.
>
> How about just:
>
> A misspelled git-grep regex revealed that smp_mb__after_spinlock()
> was misspelled in explanation.txt. This commit adds the missing "_".
Very good, updated as you suggest, thank you!
Thanx, Paul