2017-04-12 03:01:54

by Stefan Brüns

[permalink] [raw]
Subject: [PATCH 0/2] Enhancements for TI INA219/220 current/voltage monitors

The ina2xx adc driver does not handle differences between INA219/220 and
INA226/230/231 completely:

- The 219 uses a 4 bit register field for for the bus/shunt voltage adc
integration times each, whereas the 226 uses two 3 bit fields for the
integration times and an additional 3 bit averaging field.

The first patch correct setting integration times in the config register.

- The 219 also has an adjustable PGA. The default setting allows the
maximum range, but also reduces accuracy.

The second patch adds attributes for shunt PGA gain and bus voltage
range (bus voltage PGA), and sets the config register accordingly.

Stefan Brüns (2):
iio: adc: Fix integration time/averaging for INA219/220
iio: adc: Allow setting Shunt Voltage PGA gain and Bus Voltage range

drivers/iio/adc/ina2xx-adc.c | 344 ++++++++++++++++++++++++++++++++++++++++---
1 file changed, 322 insertions(+), 22 deletions(-)

--
2.12.0


2017-04-14 14:45:54

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 0/2] Enhancements for TI INA219/220 current/voltage monitors

On 12/04/17 04:01, Stefan Brüns wrote:
> The ina2xx adc driver does not handle differences between INA219/220 and
> INA226/230/231 completely:
>
> - The 219 uses a 4 bit register field for for the bus/shunt voltage adc
> integration times each, whereas the 226 uses two 3 bit fields for the
> integration times and an additional 3 bit averaging field.
>
> The first patch correct setting integration times in the config register.
>
> - The 219 also has an adjustable PGA. The default setting allows the
> maximum range, but also reduces accuracy.
>
> The second patch adds attributes for shunt PGA gain and bus voltage
> range (bus voltage PGA), and sets the config register accordingly.
>
> Stefan Brüns (2):
> iio: adc: Fix integration time/averaging for INA219/220
> iio: adc: Allow setting Shunt Voltage PGA gain and Bus Voltage range
>
> drivers/iio/adc/ina2xx-adc.c | 344 ++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 322 insertions(+), 22 deletions(-)
>
These will definitely need an Ack from Marc Titinger if possible.