2019-12-02 15:43:09

by Jack Chen

Subject: [PATCH] ARM: dts: rockchip: Add missing cpu operating points for rk3288-tinker

From: Jack Chen <[email protected]>

The Tinker Board / S devices use a special chip variant called rk3288-c
and use different operating points with a higher max frequency.

So add the missing operating points for Tinker Board / S devices, also
increase the vdd_cpu regulator-max-microvolt to 1400000 uV so that the
cpu can operate at 1.8 GHz.

Signed-off-by: Jack Chen <[email protected]>
---
arch/arm/boot/dts/rk3288-tinker.dtsi | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi
index 81e4e953d4a4..09e83b3d5e7d 100644
--- a/arch/arm/boot/dts/rk3288-tinker.dtsi
+++ b/arch/arm/boot/dts/rk3288-tinker.dtsi
@@ -113,6 +113,17 @@
cpu0-supply = <&vdd_cpu>;
};

+&cpu_opp_table {
+ opp-1704000000 {
+ opp-hz = /bits/ 64 <1704000000>;
+ opp-microvolt = <1350000>;
+ };
+ opp-1800000000 {
+ opp-hz = /bits/ 64 <1800000000>;
+ opp-microvolt = <1400000>;
+ };
+};
+
&gmac {
assigned-clocks = <&cru SCLK_MAC>;
assigned-clock-parents = <&ext_gmac>;
@@ -175,7 +186,7 @@
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <750000>;
- regulator-max-microvolt = <1350000>;
+ regulator-max-microvolt = <1400000>;
regulator-name = "vdd_arm";
regulator-ramp-delay = <6000>;
regulator-state-mem {
--
2.24.0

2019-12-03 03:57:48

by Kever Yang

Subject: Re: [PATCH] ARM: dts: rockchip: Add missing cpu operating points for rk3288-tinker

Hi Jack,

On 2019/12/2 下午11:35, Jack Chen wrote:
> From: Jack Chen <[email protected]>
>
> The Tinker Board / S devices use a special chip variant called rk3288-c
> and use different operating points with a higher max frequency.
>
> So add the missing operating points for Tinker Board / S devices, also
> increase the vdd_cpu regulator-max-microvolt to 1400000 uV so that the
> cpu can operate at 1.8 GHz.
>
> Signed-off-by: Jack Chen <[email protected]>

This patch looks good to me,


Reviewed-by: Kever Yang <[email protected]>

Thanks,
- Kever
> ---
> arch/arm/boot/dts/rk3288-tinker.dtsi | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi
> index 81e4e953d4a4..09e83b3d5e7d 100644
> --- a/arch/arm/boot/dts/rk3288-tinker.dtsi
> +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi
> @@ -113,6 +113,17 @@
> cpu0-supply = <&vdd_cpu>;
> };
>
> +&cpu_opp_table {
> + opp-1704000000 {
> + opp-hz = /bits/ 64 <1704000000>;
> + opp-microvolt = <1350000>;
> + };
> + opp-1800000000 {
> + opp-hz = /bits/ 64 <1800000000>;
> + opp-microvolt = <1400000>;
> + };
> +};
> +
> &gmac {
> assigned-clocks = <&cru SCLK_MAC>;
> assigned-clock-parents = <&ext_gmac>;
> @@ -175,7 +186,7 @@
> regulator-always-on;
> regulator-boot-on;
> regulator-min-microvolt = <750000>;
> - regulator-max-microvolt = <1350000>;
> + regulator-max-microvolt = <1400000>;
> regulator-name = "vdd_arm";
> regulator-ramp-delay = <6000>;
> regulator-state-mem {

2019-12-13 10:06:11

by Heiko Stübner

Subject: Re: [PATCH] ARM: dts: rockchip: Add missing cpu operating points for rk3288-tinker

Am Montag, 2. Dezember 2019, 16:35:40 CET schrieb Jack Chen:
> From: Jack Chen <[email protected]>
>
> The Tinker Board / S devices use a special chip variant called rk3288-c
> and use different operating points with a higher max frequency.
>
> So add the missing operating points for Tinker Board / S devices, also
> increase the vdd_cpu regulator-max-microvolt to 1400000 uV so that the
> cpu can operate at 1.8 GHz.
>
> Signed-off-by: Jack Chen <[email protected]>

applied for 5.6

Thanks
Heiko