2020-11-06 17:01:04

by Amelie Delaunay

Subject: [PATCH v5 3/5] usb: typec: stusb160x: fix power-opmode property with typec-power-opmode

Device tree property is named typec-power-opmode, not power-opmode.

Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
Signed-off-by: Amelie Delaunay <[email protected]>
Reviewed-by: Heikki Krogerus <[email protected]>
---
drivers/usb/typec/stusb160x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
index 2a618f02f4f1..d21750bbbb44 100644
--- a/drivers/usb/typec/stusb160x.c
+++ b/drivers/usb/typec/stusb160x.c
@@ -562,7 +562,7 @@ static int stusb160x_get_fw_caps(struct stusb160x *chip,
* Supported power operation mode can be configured through device tree
* else it is read from chip registers in stusb160x_get_caps.
*/
- ret = fwnode_property_read_string(fwnode, "power-opmode", &cap_str);
+ ret = fwnode_property_read_string(fwnode, "typec-power-opmode", &cap_str);
if (!ret) {
ret = typec_find_pwr_opmode(cap_str);
/* Power delivery not yet supported */
--
2.17.1

2020-11-27 13:07:14

by Amelie Delaunay

Subject: Re: [PATCH v5 3/5] usb: typec: stusb160x: fix power-opmode property with typec-power-opmode

Hi Greg,

gentle reminder for this patch, lost in the middle of a DT series (DT
part already in stm32-next).

Thanks and regards,
Amelie

On 11/6/20 5:58 PM, Amelie Delaunay wrote:
> Device tree property is named typec-power-opmode, not power-opmode.
>
> Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
> Signed-off-by: Amelie Delaunay <[email protected]>
> Reviewed-by: Heikki Krogerus <[email protected]>
> ---
> drivers/usb/typec/stusb160x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
> index 2a618f02f4f1..d21750bbbb44 100644
> --- a/drivers/usb/typec/stusb160x.c
> +++ b/drivers/usb/typec/stusb160x.c
> @@ -562,7 +562,7 @@ static int stusb160x_get_fw_caps(struct stusb160x *chip,
> * Supported power operation mode can be configured through device tree
> * else it is read from chip registers in stusb160x_get_caps.
> */
> - ret = fwnode_property_read_string(fwnode, "power-opmode", &cap_str);
> + ret = fwnode_property_read_string(fwnode, "typec-power-opmode", &cap_str);
> if (!ret) {
> ret = typec_find_pwr_opmode(cap_str);
> /* Power delivery not yet supported */
>

2020-11-27 13:12:02

by Greg Kroah-Hartman

Subject: Re: [PATCH v5 3/5] usb: typec: stusb160x: fix power-opmode property with typec-power-opmode

On Fri, Nov 27, 2020 at 02:01:29PM +0100, Amelie DELAUNAY wrote:
> Hi Greg,
>
> gentle reminder for this patch, lost in the middle of a DT series (DT part
> already in stm32-next).

Odd, I don't see this anymore, can you resend just this one so I can
apply it directly?

thanks,

greg k-h

2020-11-27 13:17:51

by Amelie Delaunay

Subject: Re: [PATCH v5 3/5] usb: typec: stusb160x: fix power-opmode property with typec-power-opmode

On 11/27/20 2:07 PM, Greg Kroah-Hartman wrote:
> On Fri, Nov 27, 2020 at 02:01:29PM +0100, Amelie DELAUNAY wrote:
>> Hi Greg,
>>
>> gentle reminder for this patch, lost in the middle of a DT series (DT part
>> already in stm32-next).
>
> Odd, I don't see this anymore, can you resend just this one so I can
> apply it directly?

Sure :) I rebase it and send it right now.

Amelie