2021-03-04 12:30:47

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 03/11] arm64: dts: intel: socfpga: override clocks by label

On 10/02/2021 18:18, Krzysztof Kozlowski wrote:
> Using full paths to extend or override a device tree node is error
> prone. If there was a typo error, a new node will be created instead of
> extending the existing node. This will lead to run-time errors that
> could be hard to detect.
>
> A mistyped label on the other hand, will cause a dtc compile error
> (during build time).
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 12 ++++--------
> .../boot/dts/intel/socfpga_agilex_socdk_nand.dts | 12 ++++--------
> arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 12 ++++--------
> 3 files changed, 12 insertions(+), 24 deletions(-)

Hi Arnd and Olof,

There was no response from Intel SoCFPGA maintainers for the DTS
patches, so maybe you could take it directly? I can provide you pull
request with these, if that's preferred. They apply cleanly.

You could also take the dt-bindings 2/11 or it could go via Rob.

About the defconfig patch (1/11) I will work on it more and resend it
with your comments (you gave me review).

Best regards,
Krzysztof