2023-12-15 09:12:08

by Bartosz Golaszewski

Subject: [PATCH] gpio: xilinx: remove excess kernel doc

From: Bartosz Golaszewski <[email protected]>

The irqchip field has been removed from struct xgpio_instance so remove
the doc as well.

Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/gpio/gpio-xilinx.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 823198368250..7348df385198 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -52,7 +52,6 @@
* @dir: GPIO direction shadow register
* @gpio_lock: Lock used for synchronization
* @irq: IRQ used by GPIO device
- * @irqchip: IRQ chip
* @enable: GPIO IRQ enable/disable bitfield
* @rising_edge: GPIO IRQ rising edge enable/disable bitfield
* @falling_edge: GPIO IRQ falling edge enable/disable bitfield
--
2.40.1

2023-12-15 11:09:31

by Michal Simek

Subject: Re: [PATCH] gpio: xilinx: remove excess kernel doc

On 12/15/23 10:09, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
>
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/gpio/gpio-xilinx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
> * @dir: GPIO direction shadow register
> * @gpio_lock: Lock used for synchronization
> * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
> * @enable: GPIO IRQ enable/disable bitfield
> * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
> * @falling_edge: GPIO IRQ falling edge enable/disable bitfield

Interesting because kernel-doc is not reporting any issue but issue is there.

Reviewed-by: Michal Simek <[email protected]>

Thanks,
Michal

2023-12-15 17:09:25

by Randy Dunlap

Subject: Re: [PATCH] gpio: xilinx: remove excess kernel doc

On 12/15/23 01:09, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
>
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> drivers/gpio/gpio-xilinx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
> * @dir: GPIO direction shadow register
> * @gpio_lock: Lock used for synchronization
> * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
> * @enable: GPIO IRQ enable/disable bitfield
> * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
> * @falling_edge: GPIO IRQ falling edge enable/disable bitfield

--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html

2023-12-18 08:57:26

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: xilinx: remove excess kernel doc

On Fri, Dec 15, 2023 at 10:09 AM Bartosz Golaszewski <[email protected]> wrote:
>
> From: Bartosz Golaszewski <[email protected]>
>
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
>
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/gpio/gpio-xilinx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
> * @dir: GPIO direction shadow register
> * @gpio_lock: Lock used for synchronization
> * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
> * @enable: GPIO IRQ enable/disable bitfield
> * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
> * @falling_edge: GPIO IRQ falling edge enable/disable bitfield
> --
> 2.40.1
>

Patch applied.

Bart