2022-10-11 14:12:17

by Krzysztof Kozlowski

Subject: [PATCH] dt-bindings: interconnect: qcom,msm8998-bwmon: Correct SC7280 CPU compatible

Two different compatibles for SC7280 CPU BWMON instance were used
in DTS and bindings. Correct the bindings to use the same one as in
DTS, because it is more specific.

Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
index 2684562df4d9..be29e0b80995 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
@@ -24,7 +24,7 @@ properties:
oneOf:
- items:
- enum:
- - qcom,sc7280-bwmon
+ - qcom,sc7280-cpu-bwmon
- qcom,sdm845-bwmon
- const: qcom,msm8998-bwmon
- const: qcom,msm8998-bwmon # BWMON v4
--
2.34.1

2022-10-12 06:23:33

by Rajendra Nayak

Subject: Re: [PATCH] dt-bindings: interconnect: qcom,msm8998-bwmon: Correct SC7280 CPU compatible

On 10/11/2022 7:37 PM, Krzysztof Kozlowski wrote:
> Two different compatibles for SC7280 CPU BWMON instance were used
> in DTS and bindings. Correct the bindings to use the same one as in
> DTS, because it is more specific.
>
> Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

ah, thanks for the fixing this,
Reviewed-by: Rajendra Nayak <[email protected]>

> ---
> .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> index 2684562df4d9..be29e0b80995 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> @@ -24,7 +24,7 @@ properties:
> oneOf:
> - items:
> - enum:
> - - qcom,sc7280-bwmon
> + - qcom,sc7280-cpu-bwmon
> - qcom,sdm845-bwmon
> - const: qcom,msm8998-bwmon
> - const: qcom,msm8998-bwmon # BWMON v4

2022-10-12 16:54:30

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: interconnect: qcom,msm8998-bwmon: Correct SC7280 CPU compatible

On Tue, 11 Oct 2022 10:07:44 -0400, Krzysztof Kozlowski wrote:
> Two different compatibles for SC7280 CPU BWMON instance were used
> in DTS and bindings. Correct the bindings to use the same one as in
> DTS, because it is more specific.
>
> Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>

2022-10-28 07:54:53

by Georgi Djakov

Subject: Re: [PATCH] dt-bindings: interconnect: qcom,msm8998-bwmon: Correct SC7280 CPU compatible

On 11.10.22 17:07, Krzysztof Kozlowski wrote:
> Two different compatibles for SC7280 CPU BWMON instance were used
> in DTS and bindings. Correct the bindings to use the same one as in
> DTS, because it is more specific.
>
> Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

I assume that this will be picked by Bjorn. Please let me know otherwise.

Acked-by: Georgi Djakov <[email protected]>

> ---
> .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> index 2684562df4d9..be29e0b80995 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> @@ -24,7 +24,7 @@ properties:
> oneOf:
> - items:
> - enum:
> - - qcom,sc7280-bwmon
> + - qcom,sc7280-cpu-bwmon
> - qcom,sdm845-bwmon
> - const: qcom,msm8998-bwmon
> - const: qcom,msm8998-bwmon # BWMON v4

2022-10-28 11:32:12

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: interconnect: qcom,msm8998-bwmon: Correct SC7280 CPU compatible

On 28/10/2022 03:14, Georgi Djakov wrote:
> On 11.10.22 17:07, Krzysztof Kozlowski wrote:
>> Two different compatibles for SC7280 CPU BWMON instance were used
>> in DTS and bindings. Correct the bindings to use the same one as in
>> DTS, because it is more specific.
>>
>> Fixes: b7c84ae757c2 ("dt-bindings: interconnect: qcom,msm8998-bwmon: Add support for sc7280 BWMONs")
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> I assume that this will be picked by Bjorn. Please let me know otherwise.
>

Bjorn marked it as not applicable, so please pick it up for interconnect.

Best regards,
Krzysztof