On Tue, Mar 31, 2009 at 5:05 AM, Andrew Morton
<[email protected]> wrote:
> On Mon, 23 Mar 2009 09:02:04 +0530
> Manish Katiyar <[email protected]> wrote:
>
>> Hi Andrew,
>>
>> Below patch converts simple_strtoul to strict_strtoul in fs/inode.c
>>
>> Signed-off-by: Manish Katiyar <[email protected]>
>> ---
>> ?fs/inode.c | ? ?8 +++++++-
>> ?1 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/inode.c b/fs/inode.c
>> index e0dad15..ef4a9b1 100644
>> --- a/fs/inode.c
>> +++ b/fs/inode.c
>> @@ -1447,9 +1447,15 @@ EXPORT_SYMBOL(inode_double_unlock);
>> ?static __initdata unsigned long ihash_entries;
>> ?static int __init set_ihash_entries(char *str)
>> ?{
>> + ? ? int ret;
>> +
>> ? ? ? if (!str)
>> ? ? ? ? ? ? ? return 0;
>> - ? ? ihash_entries = simple_strtoul(str, &str, 0);
>> +
>> + ? ? ret = strict_strtoul(str, 0, &ihash_entries);
>> + ? ? if (ret < 0 || ihash_entries == 0)
>> + ? ? ? ? ? ? return 0;
>> +
>> ? ? ? return 1;
>> ?}
>> ?__setup("ihash_entries=", set_ihash_entries);
>
> Again, there is no reason given for making the change.
Hi Andrew,
It showed up during cleanup of this file via checkpatch.pl.
>
> Bear in mind that this is not a backward-compatible change! ?If someone
> (stupidly) has
>
> ? ? ? ?ihash_entries=42foo
>
> in their grub.conf then your change would break their kernels.
>
> it's not a serious problem and we can probably make this change, but
> [email protected] is not a suitable list for discussing and
> promulgating the change.
I have cced lkml.
Thanks -
Manish
>
>