Am 2022-05-12 14:32, schrieb Pratyush Yadav:
> Hi Michael,
>
> On 12/05/22 01:20PM, Michael Walle wrote:
>> The intention was to print the JEDEC ID in the following format:
>> nn nn nn
>>
>> In this case format specifier has to be "%*ph". Fix it.
>>
>> Fixes: 0257be79fc4a ("mtd: spi-nor: expose internal parameters via
>> debugfs")
>> Reported-by: kernel test robot <[email protected]>
>> Reported-by: Dan Carpenter <[email protected]>
>> Signed-off-by: Michael Walle <[email protected]>
>> ---
>> drivers/mtd/spi-nor/debugfs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi-nor/debugfs.c
>> b/drivers/mtd/spi-nor/debugfs.c
>> index bf9fda5d4d0b..4b972bd4b80d 100644
>> --- a/drivers/mtd/spi-nor/debugfs.c
>> +++ b/drivers/mtd/spi-nor/debugfs.c
>> @@ -81,7 +81,7 @@ static int spi_nor_params_show(struct seq_file *s,
>> void *data)
>> int i;
>>
>> seq_printf(s, "name\t\t%s\n", info->name);
>> - seq_printf(s, "id\t\t%*phn\n", SPI_NOR_MAX_ID_LEN, nor->id);
>> + seq_printf(s, "id\t\t%*ph\n", SPI_NOR_MAX_ID_LEN, nor->id);
>
> Patch does not apply. Are you basing this on some other commits you
> have? This line is different on my tree:
>
> seq_printf(s, "id\t\t%*phn\n", info->id_len, info->id);
>
> In fact, I do not have a nor->id at all in my tree. BTW, I have applied
> https://lore.kernel.org/r/[email protected]
>
> I am going to apply the below patch. Please ACK/NACK. I did a quick
> test, the output stays the same before and after this patch.
>
> -- 8< --
> From c47452194641b5d27c20e557c84a46c85fd7ce37 Mon Sep 17 00:00:00 2001
> From: Michael Walle <[email protected]>
> Date: Thu, 12 May 2022 13:20:27 +0200
> Subject: [PATCH] mtd: spi-nor: debugfs: fix format specifier
>
> The intention was to print the JEDEC ID in the following format:
> nn nn nn
>
> In this case format specifier has to be "%*ph". Fix it.
>
> Fixes: 0257be79fc4a ("mtd: spi-nor: expose internal parameters via
> debugfs")
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Michael Walle <[email protected]>
> Signed-off-by: Pratyush Yadav <[email protected]>
> Link:
> https://lore.kernel.org/r/[email protected]
> ---
> drivers/mtd/spi-nor/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/debugfs.c
> b/drivers/mtd/spi-nor/debugfs.c
> index 1949905eefea..eaf84f7a0676 100644
> --- a/drivers/mtd/spi-nor/debugfs.c
> +++ b/drivers/mtd/spi-nor/debugfs.c
> @@ -81,7 +81,7 @@ static int spi_nor_params_show(struct seq_file *s,
> void *data)
> int i;
>
> seq_printf(s, "name\t\t%s\n", info->name);
> - seq_printf(s, "id\t\t%*phn\n", info->id_len, info->id);
> + seq_printf(s, "id\t\t%*ph\n", info->id_len, info->id);
> string_get_size(params->size, 1, STRING_UNITS_2, buf, sizeof(buf));
> seq_printf(s, "size\t\t%s\n", buf);
> seq_printf(s, "write size\t%u\n", params->writesize);
Ack. Thanks. My bad, there are some missing changes, which I didn't
sent yet.
-michael