2019-08-28 19:58:43

by Peter Vernia

Subject: [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example

The device-tree properties documentation-file specifies the property
"microchip,spi-present-mask" as required for MCP23SXX chips. However,
the device-tree-source example below it uses only "spi-present-mask".
Without "microchip," on the front, the driver will print "missing
spi-present-mask" when it initializes.

Update the device-tree example with the correct property-name.

Signed-off-by: Peter Vernia <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
index 625a22e2f211..8b94aa8f5971 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
@@ -82,7 +82,7 @@ gpiom1: gpio@0 {
compatible = "microchip,mcp23s17";
gpio-controller;
#gpio-cells = <2>;
- spi-present-mask = <0x01>;
+ microchip,spi-present-mask = <0x01>;
reg = <0>;
spi-max-frequency = <1000000>;
};
--
2.20.1

2019-08-29 15:01:03

by Jan Kundrát

Subject: Re: [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example

On středa 28. srpna 2019 21:56:09 CEST, Peter Vernia wrote:
> The device-tree properties documentation-file specifies the property
> "microchip,spi-present-mask" as required for MCP23SXX chips. However,
> the device-tree-source example below it uses only "spi-present-mask".
> Without "microchip," on the front, the driver will print "missing
> spi-present-mask" when it initializes.
>
> Update the device-tree example with the correct property-name.
>
> Signed-off-by: Peter Vernia <[email protected]>

Reviewed-by: Jan Kundrát <[email protected]>

> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> index 625a22e2f211..8b94aa8f5971 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> @@ -82,7 +82,7 @@ gpiom1: gpio@0 {
> compatible = "microchip,mcp23s17";
> gpio-controller;
> #gpio-cells = <2>;
> - spi-present-mask = <0x01>;
> + microchip,spi-present-mask = <0x01>;
> reg = <0>;
> spi-max-frequency = <1000000>;
> };

2019-09-02 14:41:34

by Rob Herring (Arm)

Subject: Re: [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example

On Wed, 28 Aug 2019 15:56:09 -0400, Peter Vernia wrote:
> The device-tree properties documentation-file specifies the property
> "microchip,spi-present-mask" as required for MCP23SXX chips. However,
> the device-tree-source example below it uses only "spi-present-mask".
> Without "microchip," on the front, the driver will print "missing
> spi-present-mask" when it initializes.
>
> Update the device-tree example with the correct property-name.
>
> Signed-off-by: Peter Vernia <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks.

Rob