2018-05-07 03:03:04

by Dong Bo

[permalink] [raw]
Subject: [PATCH] vfio: fix documentation

From: Dong Bo <[email protected]>

Update vfio_add_group_dev description to match the current API.

Signed-off-by: Dong Bo <[email protected]>
---
Documentation/vfio.txt | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt
index ef6a511..f1a4d3c 100644
--- a/Documentation/vfio.txt
+++ b/Documentation/vfio.txt
@@ -252,15 +252,14 @@ into VFIO core. When devices are bound and unbound to the driver,
the driver should call vfio_add_group_dev() and vfio_del_group_dev()
respectively::

- extern int vfio_add_group_dev(struct iommu_group *iommu_group,
- struct device *dev,
+ extern int vfio_add_group_dev(struct device *dev,
const struct vfio_device_ops *ops,
void *device_data);

extern void *vfio_del_group_dev(struct device *dev);

vfio_add_group_dev() indicates to the core to begin tracking the
-specified iommu_group and register the specified dev as owned by
+iommu_group of the specified dev and register the dev as owned by
a VFIO bus driver. The driver provides an ops structure for callbacks
similar to a file operations structure::

--
1.9.1


.




2018-05-07 07:53:35

by Cornelia Huck

[permalink] [raw]
Subject: Re: [PATCH] vfio: fix documentation

On Mon, 7 May 2018 11:02:10 +0800
"dongbo (E)" <[email protected]> wrote:

> From: Dong Bo <[email protected]>
>
> Update vfio_add_group_dev description to match the current API.
>
> Signed-off-by: Dong Bo <[email protected]>
> ---
> Documentation/vfio.txt | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/vfio.txt b/Documentation/vfio.txt
> index ef6a511..f1a4d3c 100644
> --- a/Documentation/vfio.txt
> +++ b/Documentation/vfio.txt
> @@ -252,15 +252,14 @@ into VFIO core. When devices are bound and unbound to the driver,
> the driver should call vfio_add_group_dev() and vfio_del_group_dev()
> respectively::
>
> - extern int vfio_add_group_dev(struct iommu_group *iommu_group,
> - struct device *dev,
> + extern int vfio_add_group_dev(struct device *dev,
> const struct vfio_device_ops *ops,
> void *device_data);
>
> extern void *vfio_del_group_dev(struct device *dev);
>
> vfio_add_group_dev() indicates to the core to begin tracking the
> -specified iommu_group and register the specified dev as owned by
> +iommu_group of the specified dev and register the dev as owned by
> a VFIO bus driver. The driver provides an ops structure for callbacks
> similar to a file operations structure::
>

Reviewed-by: Cornelia Huck <[email protected]>

2018-05-08 15:33:29

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] vfio: fix documentation

On Mon, 7 May 2018 11:02:10 +0800
"dongbo (E)" <[email protected]> wrote:

> Update vfio_add_group_dev description to match the current API.
>
> Signed-off-by: Dong Bo <[email protected]>

Applied, thanks.

jon