2024-05-02 23:34:56

by Stephen Boyd

[permalink] [raw]
Subject: [PATCH] clocksource/drivers/arm_arch_timer: Mark hisi_161010101_oem_info const

This isn't modified at runtime. Mark it const so it can move to
read-only data.

Cc: dann frazier <[email protected]>
Cc: Hanjun Guo <[email protected]>
Cc: Marc Zyngier <[email protected]>
Cc: Mark Rutland <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/clocksource/arm_arch_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 8d4a52056684..5bb43cc1a8df 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -331,7 +331,7 @@ static u64 notrace hisi_161010101_read_cntvct_el0(void)
return __hisi_161010101_read_reg(cntvct_el0);
}

-static struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
+static const struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
/*
* Note that trailing spaces are required to properly match
* the OEM table information.

base-commit: 4cece764965020c22cff7665b18a012006359095
--
https://chromeos.dev



2024-05-06 01:03:29

by Hanjun Guo

[permalink] [raw]
Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Mark hisi_161010101_oem_info const

On 2024/5/3 7:34, Stephen Boyd wrote:
> This isn't modified at runtime. Mark it const so it can move to
> read-only data.
>
> Cc: dann frazier <[email protected]>
> Cc: Hanjun Guo <[email protected]>
> Cc: Marc Zyngier <[email protected]>
> Cc: Mark Rutland <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
> drivers/clocksource/arm_arch_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 8d4a52056684..5bb43cc1a8df 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -331,7 +331,7 @@ static u64 notrace hisi_161010101_read_cntvct_el0(void)
> return __hisi_161010101_read_reg(cntvct_el0);
> }
>
> -static struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
> +static const struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
> /*
> * Note that trailing spaces are required to properly match
> * the OEM table information.

Looks good to me,

Reviewed-by: Hanjun Guo <[email protected]>

Subject: [tip: timers/core] clocksource/drivers/arm_arch_timer: Mark hisi_161010101_oem_info const

The following commit has been merged into the timers/core branch of tip:

Commit-ID: 2030a7e11f161b4067bd4eadd984cdb36446fcca
Gitweb: https://git.kernel.org/tip/2030a7e11f161b4067bd4eadd984cdb36446fcca
Author: Stephen Boyd <[email protected]>
AuthorDate: Thu, 02 May 2024 16:34:46 -07:00
Committer: Daniel Lezcano <[email protected]>
CommitterDate: Fri, 10 May 2024 10:43:21 +02:00

clocksource/drivers/arm_arch_timer: Mark hisi_161010101_oem_info const

This isn't modified at runtime. Mark it const so it can move to
read-only data.

Cc: dann frazier <[email protected]>
Cc: Hanjun Guo <[email protected]>
Cc: Marc Zyngier <[email protected]>
Cc: Mark Rutland <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
Reviewed-by: Hanjun Guo <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/clocksource/arm_arch_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 8d4a520..5bb43cc 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -331,7 +331,7 @@ static u64 notrace hisi_161010101_read_cntvct_el0(void)
return __hisi_161010101_read_reg(cntvct_el0);
}

-static struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
+static const struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
/*
* Note that trailing spaces are required to properly match
* the OEM table information.