Due to the way i2c driver matching works (falling back to the driver's
id_table if of_match_table fails) this didn't actually cause any
misbehavior, but let's add the vendor prefixes so things actually work
the way they were intended to.
Signed-off-by: Zev Weiss <[email protected]>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts | 4 ++--
arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
index 4554abf0c7cd..9aa2de3723b5 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
@@ -98,14 +98,14 @@ w83773g@4c {
/* IPB PMIC */
lm25066@40 {
- compatible = "lm25066";
+ compatible = "ti,lm25066";
reg = <0x40>;
shunt-resistor-micro-ohms = <1000>;
};
/* 12VSB PMIC */
lm25066@41 {
- compatible = "lm25066";
+ compatible = "ti,lm25066";
reg = <0x41>;
shunt-resistor-micro-ohms = <10000>;
};
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
index 6600f7e9bf5e..e830fec0570f 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
@@ -14,7 +14,7 @@ efuse##n { \
#define EFUSE(hexaddr, num) \
efuse@##hexaddr { \
- compatible = "lm25066"; \
+ compatible = "ti,lm25066"; \
reg = <0x##hexaddr>; \
shunt-resistor-micro-ohms = <675>; \
regulators { \
--
2.43.2
On Sat, Feb 24, 2024 at 02:37:07AM -0800, Zev Weiss wrote:
> Due to the way i2c driver matching works (falling back to the driver's
> id_table if of_match_table fails) this didn't actually cause any
> misbehavior, but let's add the vendor prefixes so things actually work
> the way they were intended to.
>
> Signed-off-by: Zev Weiss <[email protected]>
Oh sweet, I was just about to go off and write this patch - thanks!
Reviewed-by: Conor Dooley <[email protected]>
Cheers,
Conor.
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts | 4 ++--
> arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
> index 4554abf0c7cd..9aa2de3723b5 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
> @@ -98,14 +98,14 @@ w83773g@4c {
>
> /* IPB PMIC */
> lm25066@40 {
> - compatible = "lm25066";
> + compatible = "ti,lm25066";
> reg = <0x40>;
> shunt-resistor-micro-ohms = <1000>;
> };
>
> /* 12VSB PMIC */
> lm25066@41 {
> - compatible = "lm25066";
> + compatible = "ti,lm25066";
> reg = <0x41>;
> shunt-resistor-micro-ohms = <10000>;
> };
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
> index 6600f7e9bf5e..e830fec0570f 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
> @@ -14,7 +14,7 @@ efuse##n { \
>
> #define EFUSE(hexaddr, num) \
> efuse@##hexaddr { \
> - compatible = "lm25066"; \
> + compatible = "ti,lm25066"; \
> reg = <0x##hexaddr>; \
> shunt-resistor-micro-ohms = <675>; \
> regulators { \
> --
> 2.43.2
>
On 24/02/2024 11:37, Zev Weiss wrote:
> Due to the way i2c driver matching works (falling back to the driver's
> id_table if of_match_table fails) this didn't actually cause any
> misbehavior, but let's add the vendor prefixes so things actually work
> the way they were intended to.
>
> Signed-off-by: Zev Weiss <[email protected]>
> ---
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Sat, 24 Feb 2024 02:37:07 -0800, Zev Weiss wrote:
> Due to the way i2c driver matching works (falling back to the driver's
> id_table if of_match_table fails) this didn't actually cause any
> misbehavior, but let's add the vendor prefixes so things actually work
> the way they were intended to.
>
>
Two months passed, no replies from maintainers about picking it up. Dunno,
looks abandoned, so let me grab this. If anyone else wants to pick it up, let
me know.
Applied, thanks!
[1/1] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings
https://git.kernel.org/krzk/linux-dt/c/1afe35e54a89d762f1cf71da1ef29be2c387be35
Best regards,
--
Krzysztof Kozlowski <[email protected]>
On Wed, 2024-04-24 at 08:58 +0200, Krzysztof Kozlowski wrote:
> On Sat, 24 Feb 2024 02:37:07 -0800, Zev Weiss wrote:
> > Due to the way i2c driver matching works (falling back to the driver's
> > id_table if of_match_table fails) this didn't actually cause any
> > misbehavior, but let's add the vendor prefixes so things actually work
> > the way they were intended to.
> >
> >
>
> Two months passed, no replies from maintainers about picking it up. Dunno,
> looks abandoned, so let me grab this. If anyone else wants to pick it up, let
> me know.
Sorry, another one that fell in the hole mentioned previously.
I'm okay with it going via your tree if there are no conflicts.
Andrew