2022-06-10 02:28:47

by Wang Jingjin

Subject: [PATCH -next] m68k: coldfire: make symbol m523x_clk_lookup static

Fix sparse warnings:

arch/m68k/coldfire/m523x.c:31:19: sparse: sparse: symbol 'm523x_clk_lookup' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wang Jingjin <[email protected]>
---
arch/m68k/coldfire/m523x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/coldfire/m523x.c b/arch/m68k/coldfire/m523x.c
index 193c178162c1..83a997313393 100644
--- a/arch/m68k/coldfire/m523x.c
+++ b/arch/m68k/coldfire/m523x.c
@@ -28,7 +28,7 @@
DEFINE_CLK(pll, "pll.0", MCF_CLK);
DEFINE_CLK(sys, "sys.0", MCF_BUSCLK);

-struct clk_lookup m523x_clk_lookup[] = {
+static struct clk_lookup m523x_clk_lookup[] = {
CLKDEV_INIT(NULL, "pll.0", &clk_pll),
CLKDEV_INIT(NULL, "sys.0", &clk_sys),
CLKDEV_INIT("mcfpit.0", NULL, &clk_pll),
--
2.25.1

2022-06-13 05:12:32

by Greg Ungerer

Subject: Re: [PATCH -next] m68k: coldfire: make symbol m523x_clk_lookup static

Hi Wang,

On 10/6/22 12:07, Wang Jingjin wrote:
> Fix sparse warnings:
>
> arch/m68k/coldfire/m523x.c:31:19: sparse: sparse: symbol 'm523x_clk_lookup' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wang Jingjin <[email protected]>

Thanks. Added to the m68knommu git tree, for-next branch.

Regards
Greg


> ---
> arch/m68k/coldfire/m523x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/coldfire/m523x.c b/arch/m68k/coldfire/m523x.c
> index 193c178162c1..83a997313393 100644
> --- a/arch/m68k/coldfire/m523x.c
> +++ b/arch/m68k/coldfire/m523x.c
> @@ -28,7 +28,7 @@
> DEFINE_CLK(pll, "pll.0", MCF_CLK);
> DEFINE_CLK(sys, "sys.0", MCF_BUSCLK);
>
> -struct clk_lookup m523x_clk_lookup[] = {
> +static struct clk_lookup m523x_clk_lookup[] = {
> CLKDEV_INIT(NULL, "pll.0", &clk_pll),
> CLKDEV_INIT(NULL, "sys.0", &clk_sys),
> CLKDEV_INIT("mcfpit.0", NULL, &clk_pll),
> --
> 2.25.1
>