2019-06-17 09:36:53

by Andrew Murray

Subject: [PATCH] clocksource/arm_arch_timer: remove unused return type

The function 'arch_timer_set_evtstrm_feature' has no return statement
despite its prototype - let's change the function prototype to return
void. This matches the equivalent arm64 implementation.

fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Andrew Murray <[email protected]>
---
arch/arm/include/asm/arch_timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
index ae533caec1e9..99175812d903 100644
--- a/arch/arm/include/asm/arch_timer.h
+++ b/arch/arm/include/asm/arch_timer.h
@@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
isb();
}

-static inline bool arch_timer_set_evtstrm_feature(void)
+static inline void arch_timer_set_evtstrm_feature(void)
{
elf_hwcap |= HWCAP_EVTSTRM;
}
--
2.21.0

2019-06-17 09:46:19

by Marc Zyngier

Subject: Re: [PATCH] clocksource/arm_arch_timer: remove unused return type

On 17/06/2019 10:36, Andrew Murray wrote:
> The function 'arch_timer_set_evtstrm_feature' has no return statement
> despite its prototype - let's change the function prototype to return
> void. This matches the equivalent arm64 implementation.
>
> fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")

nit: tags start with a capital letter.

> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Andrew Murray <[email protected]>
> ---
> arch/arm/include/asm/arch_timer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
> index ae533caec1e9..99175812d903 100644
> --- a/arch/arm/include/asm/arch_timer.h
> +++ b/arch/arm/include/asm/arch_timer.h
> @@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
> isb();
> }
>
> -static inline bool arch_timer_set_evtstrm_feature(void)
> +static inline void arch_timer_set_evtstrm_feature(void)
> {
> elf_hwcap |= HWCAP_EVTSTRM;
> }
>

Acked-by: Marc Zyngier <[email protected]>

M.
--
Jazz is not dead. It just smells funny...

2019-06-17 11:48:09

by Andrew Murray

Subject: Re: [PATCH] clocksource/arm_arch_timer: remove unused return type

On Mon, Jun 17, 2019 at 10:45:24AM +0100, Marc Zyngier wrote:
> On 17/06/2019 10:36, Andrew Murray wrote:
> > The function 'arch_timer_set_evtstrm_feature' has no return statement
> > despite its prototype - let's change the function prototype to return
> > void. This matches the equivalent arm64 implementation.
> >
> > fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
>
> nit: tags start with a capital letter.

Thanks - I'll remember next time.

Andrew Murray

>
> > Reported-by: kbuild test robot <[email protected]>
> > Signed-off-by: Andrew Murray <[email protected]>
> > ---
> > arch/arm/include/asm/arch_timer.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
> > index ae533caec1e9..99175812d903 100644
> > --- a/arch/arm/include/asm/arch_timer.h
> > +++ b/arch/arm/include/asm/arch_timer.h
> > @@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
> > isb();
> > }
> >
> > -static inline bool arch_timer_set_evtstrm_feature(void)
> > +static inline void arch_timer_set_evtstrm_feature(void)
> > {
> > elf_hwcap |= HWCAP_EVTSTRM;
> > }
> >
>
> Acked-by: Marc Zyngier <[email protected]>
>
> M.
> --
> Jazz is not dead. It just smells funny...

2019-06-17 11:52:21

by Daniel Lezcano

Subject: Re: [PATCH] clocksource/arm_arch_timer: remove unused return type

On 17/06/2019 11:36, Andrew Murray wrote:
> The function 'arch_timer_set_evtstrm_feature' has no return statement
> despite its prototype - let's change the function prototype to return
> void. This matches the equivalent arm64 implementation.
>
> fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Andrew Murray <[email protected]>
> ---

I can rebase my branch. I'll fold this patch with 11e34eca5d0a

Thanks
-- Daniel


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog