2023-05-01 16:44:52

by Himanshu Bhavani

Subject: [PATCH V2 ] bindings: arm64: Add an entry in imx8mm boards for Emtop SOM-IMX8MM

From 8b789f3a997c1fbe253e9b5c5f5c370b262f7efd Mon Sep 17 00:00:00 2001
From: Himanshu Bhavani <[email protected]>
Date: Mon, 1 May 2023 21:59:47 +0530
Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM

Change in v2:
- Update vendor name
- Add board name

Signed-off-by: Himanshu Bhavani <[email protected]>

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 442ce8f4d675..06eb2c790f90 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -884,6 +884,7 @@ properties:
- beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
- boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board
- dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC
+ - emtop,imx8mm-emtop # i.MX8MM Emtop SoM
- emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
--
2.25.1

2023-05-01 17:06:08

by Marek Vasut

Subject: Re: [PATCH V2 ] bindings: arm64: Add an entry in imx8mm boards for Emtop SOM-IMX8MM

On 5/1/23 18:37, Himanshu Bhavani wrote:
>>From 8b789f3a997c1fbe253e9b5c5f5c370b262f7efd Mon Sep 17 00:00:00 2001
> From: Himanshu Bhavani <[email protected]>
> Date: Mon, 1 May 2023 21:59:47 +0530
> Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM

Can you try and use 'git send-email' to send your patch ?

git send-email --annotate [email protected] -1 HEAD

> Change in v2:
> - Update vendor name
> - Add board name

This should be ...

> Signed-off-by: Himanshu Bhavani <[email protected]>


... here, but also add '---' line above it, like so:

---
V2: - Do stuff
- Other stuff
V3: - More stuff ...

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..06eb2c790f90 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -884,6 +884,7 @@ properties:
> - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> - boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board
> - dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC
> + - emtop,imx8mm-emtop # i.MX8MM Emtop SoM

Please also update
Documentation/devicetree/bindings/vendor-prefixes.yaml with emtop vendor
prefix, do so in separate patch.