2018-07-26 02:21:58

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning after merge of the sound-asoc tree

---

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_probe':
sound/soc/amd/acp-da7219-max98357a.c:367:3: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
dev_err(&pdev->dev, "Failed to register regulator: %d\n",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ret);
~~~~

Introduced by commit

7b5317aa809f ("ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002")

This is a real bug.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2018-07-26 05:59:53

by Agrawal, Akshu

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the sound-asoc tree

---

On 7/26/2018 7:49 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_probe':
> sound/soc/amd/acp-da7219-max98357a.c:367:3: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
> dev_err(&pdev->dev, "Failed to register regulator: %d\n",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ret);
> ~~~~
>
> Introduced by commit
>
> 7b5317aa809f ("ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002")
>
> This is a real bug.
>
Posted the fix for the above warning message:
https://patchwork.kernel.org/patch/10545235/

Thanks,
Akshu