2020-08-26 16:49:37

by Randy Dunlap

Subject: [PATCH] drm: virtio: fix kconfig dependency warning

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning by using a different Kconfig symbol.

WARNING: unmet direct dependencies detected for VIRTIO_DMA_SHARED_BUFFER
Depends on [n]: VIRTIO_MENU [=n] && DMA_SHARED_BUFFER [=y]
Selected by [y]:
- DRM_VIRTIO_GPU [=y] && HAS_IOMEM [=y] && DRM [=y] && VIRTIO [=y] && MMU [=y]

Signed-off-by: Randy Dunlap <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
Found in linux-next but applies to mainline.

drivers/gpu/drm/virtio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200826.orig/drivers/gpu/drm/virtio/Kconfig
+++ linux-next-20200826/drivers/gpu/drm/virtio/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_VIRTIO_GPU
tristate "Virtio GPU driver"
- depends on DRM && VIRTIO && MMU
+ depends on DRM && VIRTIO_MENU && MMU
select DRM_KMS_HELPER
select DRM_GEM_SHMEM_HELPER
select VIRTIO_DMA_SHARED_BUFFER

2020-08-28 11:27:36

by Gerd Hoffmann

Subject: Re: [PATCH] drm: virtio: fix kconfig dependency warning

Hi,

> config DRM_VIRTIO_GPU
> tristate "Virtio GPU driver"
> - depends on DRM && VIRTIO && MMU
> + depends on DRM && VIRTIO_MENU && MMU

Shouldn't this depend on both VIRTIO and VIRTIO_MENU, simliar to the
other virtio drivers?

take care,
Gerd

2020-08-28 14:05:55

by Randy Dunlap

Subject: Re: [PATCH] drm: virtio: fix kconfig dependency warning

On 8/28/20 4:25 AM, Gerd Hoffmann wrote:
> Hi,
>
>> config DRM_VIRTIO_GPU
>> tristate "Virtio GPU driver"
>> - depends on DRM && VIRTIO && MMU
>> + depends on DRM && VIRTIO_MENU && MMU
>
> Shouldn't this depend on both VIRTIO and VIRTIO_MENU, simliar to the
> other virtio drivers?

OK, I'll send a v2.

thanks.
--
~Randy