2023-08-02 17:29:23

by Petr Tesarik

Subject: [PATCH v1] xen: remove a confusing comment on auto-translated guest I/O

From: Petr Tesarik <[email protected]>

After removing the conditional return from xen_create_contiguous_region(),
the accompanying comment was left in place, but it now precedes an
unrelated conditional and confuses readers.

Fixes: 989513a735f5 ("xen: cleanup pvh leftovers from pv-only sources")
Signed-off-by: Petr Tesarik <[email protected]>
---
arch/x86/xen/mmu_pv.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index e0a975165de7..804a5441324c 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -2310,12 +2310,6 @@ int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
int success;
unsigned long vstart = (unsigned long)phys_to_virt(pstart);

- /*
- * Currently an auto-translated guest will not perform I/O, nor will
- * it require PAE page directories below 4GB. Therefore any calls to
- * this function are redundant and can be ignored.
- */
-
if (unlikely(order > MAX_CONTIG_ORDER))
return -ENOMEM;

--
2.25.1

2023-08-02 19:34:26

by Boris Ostrovsky

Subject: Re: [PATCH v1] xen: remove a confusing comment on auto-translated guest I/O

On 8/2/23 12:31 PM, Petr Tesarik wrote:
> From: Petr Tesarik <[email protected]>
>
> After removing the conditional return from xen_create_contiguous_region(),
> the accompanying comment was left in place, but it now precedes an
> unrelated conditional and confuses readers.
>
> Fixes: 989513a735f5 ("xen: cleanup pvh leftovers from pv-only sources")
> Signed-off-by: Petr Tesarik <[email protected]>

Reviewed-by: Boris Ostrovsky <[email protected]>