2022-08-29 16:36:35

by Doug Anderson

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: arm: qcom: Adjust LTE SKUs for sc7280-villager

There have been a few changes since the patch ("dt-bindings: arm:
qcom: document sc7280 and villager board").
* New firmware reports LTE boards as "SKU 512" now. Old firmware will
still report "SKU 0", but that's all pre-production and everyone
will update.
* It's been relaized that no "-rev0" boards were ever built that were
WiFi-only. Thus we don't two entries for -rev0.

Signed-off-by: Douglas Anderson <[email protected]>
---
This builds upon the patch ("dt-bindings: arm: qcom: document sc7280
and villager board") which hasn't landed yet. In theory this could be
squashed into that patch.

Documentation/devicetree/bindings/arm/qcom.yaml | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 8e46a3c5160f..40705e2d56de 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -582,14 +582,9 @@ properties:
- const: google,villager
- const: qcom,sc7280

- - description: Google Villager with LTE (rev0)
- items:
- - const: google,villager-rev0-sku0
- - const: qcom,sc7280
-
- description: Google Villager with LTE (newest rev)
items:
- - const: google,villager-sku0
+ - const: google,villager-sku512
- const: qcom,sc7280

- items:
--
2.37.2.672.g94769d06f0-goog


2022-08-30 10:05:51

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Adjust LTE SKUs for sc7280-villager

On 29/08/2022 18:48, Douglas Anderson wrote:
> There have been a few changes since the patch ("dt-bindings: arm:
> qcom: document sc7280 and villager board").
> * New firmware reports LTE boards as "SKU 512" now. Old firmware will
> still report "SKU 0", but that's all pre-production and everyone
> will update.
> * It's been relaized that no "-rev0" boards were ever built that were
> WiFi-only. Thus we don't two entries for -rev0.
>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---
> This builds upon the patch ("dt-bindings: arm: qcom: document sc7280
> and villager board") which hasn't landed yet. In theory this could be
> squashed into that patch.

Unless Bjorn already merged it, this should be squashed.

Best regards,
Krzysztof

2022-08-30 18:38:23

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Adjust LTE SKUs for sc7280-villager

Hi,

On Tue, Aug 30, 2022 at 2:44 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 29/08/2022 18:48, Douglas Anderson wrote:
> > There have been a few changes since the patch ("dt-bindings: arm:
> > qcom: document sc7280 and villager board").
> > * New firmware reports LTE boards as "SKU 512" now. Old firmware will
> > still report "SKU 0", but that's all pre-production and everyone
> > will update.
> > * It's been relaized that no "-rev0" boards were ever built that were
> > WiFi-only. Thus we don't two entries for -rev0.
> >
> > Signed-off-by: Douglas Anderson <[email protected]>
> > ---
> > This builds upon the patch ("dt-bindings: arm: qcom: document sc7280
> > and villager board") which hasn't landed yet. In theory this could be
> > squashed into that patch.
>
> Unless Bjorn already merged it, this should be squashed.

Sure. Squashed as v9 of Jimmy's patches.

https://lore.kernel.org/r/[email protected]

-Doug

2022-09-15 03:38:34

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/2] dt-bindings: arm: qcom: Adjust LTE SKUs for sc7280-villager

On Mon, 29 Aug 2022 08:48:23 -0700, Douglas Anderson wrote:
> There have been a few changes since the patch ("dt-bindings: arm:
> qcom: document sc7280 and villager board").
> * New firmware reports LTE boards as "SKU 512" now. Old firmware will
> still report "SKU 0", but that's all pre-production and everyone
> will update.
> * It's been relaized that no "-rev0" boards were ever built that were
> WiFi-only. Thus we don't two entries for -rev0.
>
> [...]

Applied, thanks!

[1/2] dt-bindings: arm: qcom: Adjust LTE SKUs for sc7280-villager
commit: ff0ea86a538e80879243364bcf1a42e2d0eb6254
[2/2] arm64: dts: qcom: sc7280-villager: Adjust LTE SKUs
commit: 68aa834823e09a540a23374129326a51efe877a3

Best regards,
--
Bjorn Andersson <[email protected]>