2023-10-19 03:14:29

by Jiapeng Chong

Subject: [PATCH] tracefs/eventfs: Modify mismatched function name

No functional modification involved.

fs/tracefs/event_inode.c:864: warning: expecting prototype for eventfs_remove(). Prototype was for eventfs_remove_dir() instead.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6939
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/tracefs/event_inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
index 1ccd100bc565..ba9d1cb0d24c 100644
--- a/fs/tracefs/event_inode.c
+++ b/fs/tracefs/event_inode.c
@@ -855,7 +855,7 @@ static void unhook_dentry(struct dentry **dentry, struct dentry **list)
}
}
/**
- * eventfs_remove - remove eventfs dir or file from list
+ * eventfs_remove_dir - remove eventfs dir or file from list
* @ei: eventfs_inode to be removed.
*
* This function acquire the eventfs_mutex lock and call eventfs_remove_rec()
--
2.20.1.7.g153144c

2023-10-23 09:23:18

by Mukesh Ojha

Subject: Re: [PATCH] tracefs/eventfs: Modify mismatched function name

On 10/19/2023 8:43 AM, Jiapeng Chong wrote:
> No functional modification involved.
>
> fs/tracefs/event_inode.c:864: warning: expecting prototype for eventfs_remove(). Prototype was for eventfs_remove_dir() instead.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6939
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Mukesh Ojha <[email protected]>

-Mukesh
> ---
> fs/tracefs/event_inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
> index 1ccd100bc565..ba9d1cb0d24c 100644
> --- a/fs/tracefs/event_inode.c
> +++ b/fs/tracefs/event_inode.c
> @@ -855,7 +855,7 @@ static void unhook_dentry(struct dentry **dentry, struct dentry **list)
> }
> }
> /**
> - * eventfs_remove - remove eventfs dir or file from list
> + * eventfs_remove_dir - remove eventfs dir or file from list
> * @ei: eventfs_inode to be removed.
> *
> * This function acquire the eventfs_mutex lock and call eventfs_remove_rec()