2021-05-12 06:25:49

by Zou Wei

Subject: [PATCH -next] dmaengine: s3c24xx: add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/dma/s3c24xx-dma.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
index 8e14c72..f1ebaa6 100644
--- a/drivers/dma/s3c24xx-dma.c
+++ b/drivers/dma/s3c24xx-dma.c
@@ -1175,6 +1175,7 @@ static const struct platform_device_id s3c24xx_dma_driver_ids[] = {
},
{ },
};
+MODULE_DEVICE_TABLE(platform, s3c24xx_dma_driver_ids);

static struct soc_data *s3c24xx_dma_get_soc_data(struct platform_device *pdev)
{
--
2.6.2

2021-05-12 11:48:31

by Krzysztof Kozlowski

Subject: Re: [PATCH -next] dmaengine: s3c24xx: add missing MODULE_DEVICE_TABLE

On 12/05/2021 02:39, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.


Hi,

Thanks for the patch. It cannot be built as a module.

>
> Reported-by: Hulk Robot <[email protected]>

Please make the reports public. This is open source work and public
collaboration.

Best regards,
Krzysztof