2022-06-27 03:54:08

by Liang Yang

Subject: [PATCH v8 5/5] mtd: rawnand: meson: not support legacy clock

meson NFC driver use common clock interfaces. so the test robot report
some errors once using the legacy clock with HAVE_LEGACY_CLK on.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Liang Yang <[email protected]>
---
drivers/mtd/nand/raw/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 67b7cb67c030..c309cfeb74cd 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -395,7 +395,7 @@ config MTD_NAND_STM32_FMC2

config MTD_NAND_MESON
tristate "Support for NAND controller on Amlogic's Meson SoCs"
- depends on ARCH_MESON || COMPILE_TEST
+ depends on COMMON_CLK && (ARCH_MESON || COMPILE_TEST)
select MFD_SYSCON
help
Enables support for NAND controller on Amlogic's Meson SoCs.
--
2.34.1

2022-06-27 07:36:46

by Neil Armstrong

Subject: Re: [PATCH v8 5/5] mtd: rawnand: meson: not support legacy clock

On 27/06/2022 05:17, Liang Yang wrote:
> meson NFC driver use common clock interfaces. so the test robot report
> some errors once using the legacy clock with HAVE_LEGACY_CLK on.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Liang Yang <[email protected]>
> ---
> drivers/mtd/nand/raw/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 67b7cb67c030..c309cfeb74cd 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -395,7 +395,7 @@ config MTD_NAND_STM32_FMC2
>
> config MTD_NAND_MESON
> tristate "Support for NAND controller on Amlogic's Meson SoCs"
> - depends on ARCH_MESON || COMPILE_TEST
> + depends on COMMON_CLK && (ARCH_MESON || COMPILE_TEST)
> select MFD_SYSCON
> help
> Enables support for NAND controller on Amlogic's Meson SoCs.

Reviewed-by: Neil Armstrong <[email protected]>