- Adds quirks for various ASUS ROG laptops.
- Fixes up a previous quirk
- Fixes up a whitespace error
This introduces a quirk chain that is similar to the ROG Ally quirk chain, but
due to the verb configs being currently tested these new quirks do not use it
and instead add a new chain. It is likely the Ally quirk will be removed in
favour of this new chain in future.
Luke D. Jones (5):
ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
ALSA: hda/realtek: Add quirk for ASUS ROG GA402X
ALSA: hda/realtek: Amend G634 quirk to enable rear speakers
ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx
Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for Dell
DT)
sound/pci/hda/patch_realtek.c | 35 +++++++++++++++++++++++++++++++++--
1 file changed, 33 insertions(+), 2 deletions(-)
--
2.41.0
Adds the required quirk to enable the Cirrus amp and correct pins
on the ASUS ROG G614J series which uses an SPI connected Cirrus amp.
While this works if the related _DSD properties are made available, these
aren't included in the ACPI of these laptops (yet).
Signed-off-by: Luke D. Jones <[email protected]>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 50becdc86daa..ba3c113f0be1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9632,6 +9632,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1c23, "Asus X55U", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
SND_PCI_QUIRK(0x1043, 0x1c92, "ASUS ROG Strix G15", ALC285_FIXUP_ASUS_G533Z_PINS),
+ SND_PCI_QUIRK(0x1043, 0x1c9f, "ASUS G614JI", ALC285_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x1caf, "ASUS G634JYR/JZR", ALC285_FIXUP_ASUS_SPI_REAR_SPEAKERS),
SND_PCI_QUIRK(0x1043, 0x1ccd, "ASUS X555UB", ALC256_FIXUP_ASUS_MIC),
SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401),
--
2.41.0
On Tue, 04 Jul 2023 06:46:14 +0200,
Luke D. Jones wrote:
>
> - Adds quirks for various ASUS ROG laptops.
> - Fixes up a previous quirk
> - Fixes up a whitespace error
>
> This introduces a quirk chain that is similar to the ROG Ally quirk chain, but
> due to the verb configs being currently tested these new quirks do not use it
> and instead add a new chain. It is likely the Ally quirk will be removed in
> favour of this new chain in future.
>
> Luke D. Jones (5):
> ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
> ALSA: hda/realtek: Add quirk for ASUS ROG GA402X
> ALSA: hda/realtek: Amend G634 quirk to enable rear speakers
> ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx
> Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for Dell
> DT)
Now applied all patches. The subject line of the last patch was
modified to match with the standard. The Fixes tag was moved to the
right place, too.
thanks,
Takashi
On Tue, 2023-07-04 at 08:44 +0200, Takashi Iwai wrote:
> On Tue, 04 Jul 2023 06:46:14 +0200,
> Luke D. Jones wrote:
> >
> > - Adds quirks for various ASUS ROG laptops.
> > - Fixes up a previous quirk
> > - Fixes up a whitespace error
> >
> > This introduces a quirk chain that is similar to the ROG Ally quirk
> > chain, but
> > due to the verb configs being currently tested these new quirks do
> > not use it
> > and instead add a new chain. It is likely the Ally quirk will be
> > removed in
> > favour of this new chain in future.
> >
> > Luke D. Jones (5):
> > ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
> > ALSA: hda/realtek: Add quirk for ASUS ROG GA402X
> > ALSA: hda/realtek: Amend G634 quirk to enable rear speakers
> > ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx
> > Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for
> > Dell
> > DT)
>
> Now applied all patches. The subject line of the last patch was
> modified to match with the standard. The Fixes tag was moved to the
> right place, too.
Thanks mate. I looked at the patch guidelines for that but I must have
misunderstood it :)