2023-06-15 16:43:59

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion

The of_gpio.h is not and shouldn't be used in the GPIO drivers.
Remove it.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/gpio/gpio-lpc18xx.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c
index d711ae06747e..ed3f653a1dfc 100644
--- a/drivers/gpio/gpio-lpc18xx.c
+++ b/drivers/gpio/gpio-lpc18xx.c
@@ -14,7 +14,6 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_address.h>
-#include <linux/of_gpio.h>
#include <linux/of_irq.h>
#include <linux/pinctrl/consumer.h>
#include <linux/platform_device.h>
--
2.40.0.1.gaa8946217a0b



2023-06-15 19:08:02

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion

On Thu, Jun 15, 2023 at 6:25 PM Andy Shevchenko
<[email protected]> wrote:

> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-06-15 23:58:48

by Vladimir Zapolskiy

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion

On 6/15/23 19:25, Andy Shevchenko wrote:
> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---

Thank you for the correct change.

Acked-by: Vladimir Zapolskiy <[email protected]>

--
Best wishes,
Vladimir

2023-06-19 12:49:13

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] gpio: lpc18xx: Remove unused of_gpio.h inclusion

On Thu, Jun 15, 2023 at 6:25 PM Andy Shevchenko
<[email protected]> wrote:
>
> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/gpio/gpio-lpc18xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c
> index d711ae06747e..ed3f653a1dfc 100644
> --- a/drivers/gpio/gpio-lpc18xx.c
> +++ b/drivers/gpio/gpio-lpc18xx.c
> @@ -14,7 +14,6 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> -#include <linux/of_gpio.h>
> #include <linux/of_irq.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> --
> 2.40.0.1.gaa8946217a0b
>

Applied, thanks!

Bart