2018-01-07 21:28:40

by SF Markus Elfring

Subject: [PATCH 0/2] misc/fsa9480: Adjustments for fsa9480_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 7 Jan 2018 22:26:44 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/misc/fsa9480.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.15.1

2018-01-07 21:29:29

by SF Markus Elfring

Subject: [PATCH 1/2] misc/fsa9480: Delete an error message for a failed memory allocation in fsa9480_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 7 Jan 2018 22:17:53 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/misc/fsa9480.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/misc/fsa9480.c b/drivers/misc/fsa9480.c
index 71d2793b372c..4d7f763195bc 100644
--- a/drivers/misc/fsa9480.c
+++ b/drivers/misc/fsa9480.c
@@ -418,10 +418,8 @@ static int fsa9480_probe(struct i2c_client *client,
return -EIO;

usbsw = kzalloc(sizeof(struct fsa9480_usbsw), GFP_KERNEL);
- if (!usbsw) {
- dev_err(&client->dev, "failed to allocate driver data\n");
+ if (!usbsw)
return -ENOMEM;
- }

usbsw->client = client;
usbsw->pdata = client->dev.platform_data;
--
2.15.1

2018-01-07 21:30:18

by SF Markus Elfring

Subject: [PATCH 2/2] misc/fsa9480: Improve a size determination in fsa9480_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 7 Jan 2018 22:20:19 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/misc/fsa9480.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/fsa9480.c b/drivers/misc/fsa9480.c
index 4d7f763195bc..bf199cd5fce9 100644
--- a/drivers/misc/fsa9480.c
+++ b/drivers/misc/fsa9480.c
@@ -417,7 +417,7 @@ static int fsa9480_probe(struct i2c_client *client,
if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
return -EIO;

- usbsw = kzalloc(sizeof(struct fsa9480_usbsw), GFP_KERNEL);
+ usbsw = kzalloc(sizeof(*usbsw), GFP_KERNEL);
if (!usbsw)
return -ENOMEM;

--
2.15.1